RMMV Any reason this doesn't change the text?

[Morpheus]

Window_ShopCommand.prototype.makeCommandList = function() {
    this.addCommand(TextManager.buy,    'buy');
    //this.addCommand(TextManager.sell,   'sell',   !this._purchaseOnly);
    this.addCommand(TextManager.cancel, 'finish');
};

It correctly removes the sell option but for some reason doesn't change 'cancel' to 'finish'.

 

[SeaPhoenix]

It looks like you changed the original

this.addCommand(TextManager.cancel, 'cancel');

to

this.addCommand(TextManager.cancel, 'finish');

The text that's shown in the game is the first argument in the function above (TextManager.cancel, which refers to whatever you have in the Database > Terms > Cancel). The second argument, which was originally 'cancel' but which you changed to 'finish', is actually a symbol that's called by the setHandler function in rpg_scenes.js to perform an action (i.e., act as a Cancel button).

So unless you actually created a new setHandler function for 'finish' your new code won't do anything (and may show an error in the console when you select it) and the term in the database for 'Cancel' will still be used.

Long story short, if you just want to change the text in this particular screen to 'Finish' and retain its functionality as the 'Cancel' button, do this:

this.addCommand('Finish', 'cancel');

Alternatively, if you want every menu to show 'Finish' instead of 'Cancel', stick to the original Javascript code but change the term in the Database instead.

 

[Morpheus]

It looks like you changed the original

this.addCommand(TextManager.cancel, 'cancel');

to

this.addCommand(TextManager.cancel, 'finish');

The text that's shown in the game is the first argument in the function above (TextManager.cancel, which refers to whatever you have in the Database > Terms > Cancel). The second argument, which was originally 'cancel' but which you changed to 'finish', is actually a symbol that's called by the setHandler function in rpg_scenes.js to perform an action (i.e., act as a Cancel button).

So unless you actually created a new setHandler function for 'finish' your new code won't do anything (and may show an error in the console when you select it) and the term in the database for 'Cancel' will still be used.

Long story short, if you just want to change the text in this particular screen to 'Finish' and retain its functionality as the 'Cancel' button, do this:

this.addCommand('Finish', 'cancel');

Alternatively, if you want every menu to show 'Finish' instead of 'Cancel', stick to the original Javascript code but change the term in the Database instead.

Big OOF from me, been working with MV for a long time and never realized I could change the shop text in the editor. Thank you...