Oh yea, it would have to be an extreme case for such a thing to occur.
Personally I think a rewrite of the refresh method would be great (not only for battlerbase, but for everything)- but only to place each line of code into its own method... For example...
class Game_BattlerBase def refresh state_resist_set.each {|state_id| erase_state(state_id) } @hp = [[@hp, mhp].min, 0].max @mp = [[@mp, mmp].min, 0].max @hp == 0 ? add_state(death_state_id) : remove_state(death_state_id) endendBeing rewritten into something like
class Game_BattlerBase def refresh refresh_state_resist refresh_hp_set refresh_mp_set refresh_death_state end def refresh_state_resist state_resist_set.each {|state_id| erase_state(state_id) } end def refresh_hp_set @hp = [[@hp, mhp].min, 0].max end def refresh_mp_set @mp = [[@mp, mmp].min, 0].max end def refresh_death_state @hp == 0 ? add_state(death_state_id) : remove_state(death_state_id) endendObviously doing this is completely unnecessary, but its also alot cleaner and leaves alot more room for 3r party modification. Hopefully the next RPGMaker is structured as such. That will make for many easy to make scripts with high chance of compatibility
Also - have to remember as well, alof of new scripters - the ones like me, who started by modifying other scripts rather than learn the language first - dont fully understand the power of super or even aliasing. Obviously, once they are more familiarized with writing code in general it rarely happens, but the mistakes people make can 'haunt them' forever...
My first script was the 'Perfect Stat Point Distribution System' < Which has many flaws. I later rewrote that system into my 'Insane Stat Point Distribution System' < Which is much better in terms of efficient code and features. Yet still, my PSPDS has gained just as many views this year as my ISPDS.
Is a complete pain in the ass - when you know there is a better script available (and have stated that on the script download page) yet people continue to use the old inefficient model...
Anyway... I'm rambling now...