Burning Orca Shops

[ShadowDragon]

MKR worked before (still have the older version) and it gave a meta error, might be
because of it, not sure why, but I asked if they can make it compatable, because
it can become very handy.

but I never tested it on switches before, I think because switches doesn't have
a meta notetag field, so it would be probabl impossible to get that to work.

but its an amazing plugin.
for my use, the XL version does it's job on my end, so it doesn't give much of a problem.
except for the JS part what I can do with it in ES6 which I dont know.
I know a little of ES5 only.

 

[BurningOrca]

Well XL didn't work, because my class Game_ShopGood which I used instead of the regular array, that normally presents shop goods, didn't have a meta property either. But now I added an empty meta object to Game_ShopGoods of type Switch and copied over the meta object of item/weapons/armor to Game_ShopGood, so it should work now. It was my fault, that it didn't work, so I had to fix it.

I don't understand the question about ES6. My classes in the XL version are written in ES6, but if you need to use any javascript with my plugin using ES5 is still fine.

 

[ShadowDragon]

will test out and see if its working.

EDIT:
MKR plugin is working smoothly again and doesn't crash on switch.
while the switch otherwise show the shopname, but no idea if switch can have
meta's in general though.

I might need to see a work around on this one, item -> use -> switch activate.
but thank you to make it work again because it can be really usefull for custom
shop message.

instead of "potion description: this heal for 500HP", with MKR ON and set the notetag
you can see: "this potion can be found everywhere" or another text.

I wonder how to do this with switches though. because switches doesn't have notetags.

 

[BurningOrca]

It can't be done with switches. They don't have notetags. I would have to add a note parameter it in the plugin parameters. However I am not sure if I will to that. I'm currently not planning to add more features, just bug fixes.

 

[TheGameAfter]

Edit: Great plugin, thanks for the time you put for it, by the way, I create a small resource post for shop system, I put your new version and your old version as in my resources post, you can see it here (at the top). thanks again for an amazing plugin.

 

[BurningOrca]

Found some math errors in XL and removed them.

Edit:
I now also found a bug in XL for the refill of a single item/armor/weapon.

 

[SmashArtist]

Hey there!
I'm using your plugin and decided to put in some conditional discounts, but when the condition is met it throws a "$dataArmor is not defined" error.
I've disabled all my plugins and I still get this error. It also gives this error in an empty new project.
This seems to only happen when you have armor being sold in the shop.
This is how I have the condition set up:
Condition: $gameVariables.value(45) === 1; (changing the condition doesn't seem to stop the error)
Percentage: 25 (though changing this doesn't effect the error at all)

Let me know if you need any other information.

 

[BurningOrca]

@SmashArtist: Sorry, that was a typo. Should have been $dataArmors.

Other quick update: I would have a version ready that seems to work in MZ, but cannot upload it, because I would only be able to support it for another 13 days until trial license expires.

 

[SmashArtist]

Ah alright, easy fix.

 

[BurningOrca]

Found a bug in RefillItemStock of the normal BO_CustomShops.

Edit:
I've now changed my mind and thus the terms of use regarding MZ. Sorry, I won't allow anyone to port it over to MZ. I've tried porting XL during my MZ trial period and it seems to work fine standalone, but is completely incompatible to VisuStella and that is my fault for changing how shop goods are defined in XL from an array of arrays to an array of my new class Game_ShopGood. This simply can't work well with other shop plugins without major workarounds. Next up I've tried to port the normal one, yet again seeming to work fine standalone and I also seem to have achieved a version that is logical compatible to VisuStella, which means it seems to cause no errors. It is still not fully functional compatible to VS, because my Switch Shops won't work with VS installed and the currency unit will be displayed next to the Sold Out Text. I don't really need to get compatible to VS, but I really wished to get compatible. I guess contaticting someone from the VS Team wouldn't change anything, because I've added new functionality, which is just incompatible by nature. You can clearly see that on how many compatibility fixes to YEP plugins where needed for the MV versions, just because of the way I've wrote them.
I came to the conclusion that it might be an option to write an own Item & Shop based plugin library if I ever get a full version of MZ.

 

[BurningOrca]

Sorry for posting under myself. I just don't know if otherwise the users who watch this thread would get notifications.
I've found serious bugs in XL. Shops weren't even working after loading a safe file.
Also I've changed my mind from yesterday and actually uploaded a MZ Version based on XL and I actually had an idea to make it at least partially compatible to Visustella: Some drawing functions and UI Styles don't work exactly correct, but I need to go to bed now.
Also my trial license of MZ runs out tomorrow, which is why I won't be able to support this plugin for a while. It is just experimental.

Edit:
Yet again introduced a small little bug with the fixes in XL yesterday.

 

[TheGameAfter]

Sorry for posting under myself. I just don't know if otherwise the users who watch this thread would get notifications.
I've found serious bugs in XL. Shops weren't even working after loading a safe file.
Also I've changed my mind from yesterday and actually uploaded a MZ Version based on XL and I actually had an idea to make it at least partially compatible to Visustella: Some drawing functions and UI Styles don't work exactly correct, but I need to go to bed now.
Also my trial license of MZ runs out tomorrow, which is why I won't be able to support this plugin for a while. It is just experimental.

Edit:
Yet again introduced a small little bug with the fixes in XL yesterday.

Hey BurningOrca, your shop plugin is the top of the line, I don't think you should be worried about MZ right now, there is still a lot they need o work on to make it stable, and many MV users like me the buy MZ still prefer using MV, for now, so you could just continue to support the plugin with the MZ version, I'm sure many people like me would love to use your shop system in their MV games, I really don't think there is a better shop system for mv, and I found many as you know please continue to support the plugin in the MV version, we all love your shop plugin!

 

[BurningOrca]

@TheGameAfter: Yes I will continue to support the plugin in MV version.
I ment I cannot support it in MZ version, because trial did run out.
Maybe I shouldn't have uploaded it at all. Also I didn't open a new thread in MZ plugin releases because of this. I guess nobody that is actively using MZ will search for it in the MV threads.

Edit:
I've taken the MZ version down. Read more about that in the first post of this thread.

 

[BurningOrca]

To tell the truth while I was writing XL I've got a idea for a 3rd version, a lunatic version, that allows a lot of Javascript to be entered in the plugin parameters, but I've never really written it.
Now I don't think it's necessary anymore.

Just a question: Do you still recognize it, if I change the original post in this thread, without me writing the exact same thing into a new post.

If not I've added Edit 27 and uploaded a new version of XL. The new version will be required for a little extension plugin I am currently writing.

 

[ShadowDragon]

totally lunatic version is probably only for the very advanced javascript coders to setup.
which I cannot do yet.

but the extension can be possible if you want too, but I cant use that
but the question is also, how man people can and will use it?

it's totally up to you =)

 

[TheGameAfter]

To tell the truth while I was writing XL I've got a idea for a 3rd version, a lunatic version, that allows a lot of Javascript to be entered in the plugin parameters, but I've never really written it.
Now I don't think it's necessary anymore.

It will only works if you add something like '.json' file the is optional to use to edit/create the shop, but should be only optional if so, I think is better to improve the easy interface of the plugin and the shop set up, maybe add more control on the sence size/look or adding icons/images...

Just a question: Do you still recognize it, if I change the original post in this thread, without me writing the exact same thing into a new post.

It will be recognize it if you add a note on start of this post tell people there is a new post + a link.

 

[BurningOrca]

I had to update it again. It was still not working exactly as I've intended.

Edit:
And guess what, I've found another bug in my reworked stock refill.

 

[BurningOrca]

About .json files:

If they should be a option to create the shops, then I have to say no, this would make the plugin to complex. It is already feature bload.

Making them mandatory, replacing the plugin parameters, but only in an entirely new plugin, that is ment for MZ, but would also work in MV, is actually an option to consider.

Advantages:
- The plugin could be split into more plugins, each covering a single functionality (like seperate plugin for Switch Shops, Discounts, Sellable Item Restrictions), making everything more modular.
- Easier to extend, e.g. adding Skill Shops (don't know why I have this idea, cause you actually could sell items that teach skills already). Other people could write extensions aswell.

Disadvantages:
- .json files are harder to setup than the plugin parameters.
I would have to write a Graphical User Interface which allows to create and edit shops and which creates the .json files for the users. The best option for this would actually be a HTML based editor like those shipped with SRD Plugins, but I don't know how to do this. I am also pretty sure it would be against SRD's terms of use to just copy it from his plugins. The other option would be a Windows Forms Application, but then it would be Windows only.

The only other option I have to make a new version more modular would be to make the users repeat the shop name and each plugin's parameters and match the parameters together by the shop name.

But my users are satified with this version, so there is no need to write a new one. Also with a new one the compatibility to other plugins might not be given anymore. But don't worry, I won't just write a new one and discontinue supporting this one. If I'd ever release a new shop plugin or shop plugin library, I would still continue to support this one.

 

[TheGameAfter]

About .json files:

If they should be a option to create the shops, then I have to say no, this would make the plugin to complex. It is already feature bload.

Making them mandatory, replacing the plugin parameters, but only in an entirely new plugin, that is ment for MZ, but would also work in MV, is actually an option to consider.

Advantages:
- The plugin could be split into more plugins, each covering a single functionality (like seperate plugin for Switch Shops, Discounts, Sellable Item Restrictions), making everything more modular.
- Easier to extend, e.g. adding Skill Shops (don't know why I have this idea, cause you actually could sell items that teach skills already). Other people could write extensions aswell.

Disadvantages:
- .json files are harder to setup than the plugin parameters.
I would have to write a Graphical User Interface which allows to create and edit shops and which creates the .json files for the users. The best option for this would actually be a HTML based editor like those shipped with SRD Plugins, but I don't know how to do this. I am also pretty sure it would be against SRD's terms of use to just copy it from his plugins. The other option would be a Windows Forms Application, but then it would be Windows only.

The only other option I have to make a new version more modular would be to make the users repeat the shop name and each plugin's parameters and match the parameters together by the shop name.

But my users are satified with this version, so there is no need to write a new one. Also with a new one the compatibility to other plugins might not be given anymore. But don't worry, I won't just write a new one and discontinue supporting this one. If I'd ever release a new shop plugin or shop plugin library, I would still continue to support this one.

I think your shop plugin are just fine, there is no need for remake, and I agree is easier to setup the setting from the plugin parmeter rather then from .json file, your plugin is 'complete' and unless you really want to create another type/way for shops you done a great job with this one, and I will probebly use thsi one anyway.

About the idea for the plugin to wokr mv and mz, to be honest some of those 'both engnie' plugins will not work with mv when you use some complex plugins (abs, pixel movement), not all the time is dapends on the plugin of course, however what I'm trying to say is, better to create a seperate one for mz and keep this one for mv, I'm sure is a way to fix it and make them work with complex plugins but not sure how easy that will be, is not always will be an 'error, in my case I have mv-mz plugins the didn't show error, but nothing happend in the engnie when using the scripts (for the spcific engnie), but maybe with shop plugin it will not be a probelm since it dosen't use the same part of the engnie as those complex plugins.

In short, I think is better to create a seperate plugin for MZ, and your mv plugin are fine as it's and if anyone have bug or not work with somthing that will be the time to add 'x' y' to fix it but there is no need for you to change the way it's now.

Edit: Just a new idea for the shop will be to add an option for extra space where you can add an image of the shop owner, either just the face or a full body image (unless I miss this feature?).

 

[BurningOrca]

NPCDialogueShop has this feature as far as I know. I don't use this plugin, but the first users of my plugin really liked it, so I made mine as compatible as possible.