DreamX's Victory Aftermath Extension

DreamX

Veteran
Veteran
Joined
May 30, 2015
Messages
816
Reaction score
818
First Language
English
Primarily Uses
} else if (currentPriority > highestPriority) {
priorityEffects = [];
priorityEffects.push(currentEffect);
}


You forgot to actually set highestPriority to currentPriority in this branch, so every action with a non-zero priority is treated as though it had a higher priority than whatever action was processed immediately beforehand, while any zero priority actions processed afterwards will be treated as though they had equal priority to it.


But thanks for this; I was afraid I'd have to write my own victory quotes extension, and this does so much more than just victory quotes.
Thanks for the catch, it's been changed in the latest update just now.

Hey, DreamX, I've been having a "bug" where sometimes, after the last enemy is killed, another action takes place during the Victory Screen. Only after I perform another action the quotes show up.


Could this be the cause to it? I tried messing with the code a little bit but couldn't fix it. Any ideas?
Try the latest update and if it still has problems, please upload a demo using this http://himeworks.com/2016/01/super-small-debug-demo/


showcasing the problem to dropbox.com and I'll try to fix it.
 

Verdelite

Wannabe Developer
Veteran
Joined
May 22, 2016
Messages
144
Reaction score
1,041
First Language
German
Primarily Uses
RMMV
Hello @DreamX,


I'm using your plugin in conjunction with Yanfly's CTB.


I'm encountering the problem that after the battle when the experience screen shows, it will sometimes only load the actor faces and the assigned victory quotes, but not the actor names or the exp gained for a while. They do show up eventually, but it takes very long, although the wait time for them to appear varies,


I'm not sure if it's just superstition, but I feel like this problem occurs more often when I only have a single actor in battle.


I don't have any fancy events set up for the victory quotes, just a single text message.
 
Last edited by a moderator:

JohnnyR

Dungeon Master
Restaff
Joined
Mar 27, 2013
Messages
275
Reaction score
135
First Language
English
Primarily Uses
RMMV
Try the latest update and if it still has problems, please upload a demo using this http://himeworks.com/2016/01/super-small-debug-demo/


showcasing the problem to dropbox.com and I'll try to fix it.
Well, sorry for such a late reply, but anyway.. I found the bug. Apparently what is causing said behavior is Yanfly's ATB system. I tried all sorts of combinations, by that I mean moving stuff to other places in the scripts list. However, it seems that just by having ATB on, the characters will take another turn during the aftermath screen, before your script's message appears. Could you test this out to see if it really is a bug with that script or if I still have something wrong in my setup?

Also, even with Hime's plugin, a demo of my project would still be really big, so I'd rather not go through that. lol
 

Lear

Veteran
Veteran
Joined
Aug 12, 2012
Messages
56
Reaction score
11
Primarily Uses
Well, sorry for such a late reply, but anyway.. I found the bug.
I was also having the issue and am glad you figured out what the cause was. Would be great to get a patch for this!
 

VictoryStar

Warper
Member
Joined
Mar 9, 2017
Messages
1
Reaction score
0
First Language
English
Primarily Uses
N/A
This is a great extension, but i'm curious if it's possible to allow the lead character in the party to display a victory quote after the battle. Like: ex. "I won, you can't beat me!" I know VX Ace had that in Yanfly's script with notetags in the actor box and I really liked it. Is that possible with this, or would there be a plugin allowing this?
 

AirTsunami

Number 4 Hater
Member
Joined
Aug 6, 2016
Messages
1
Reaction score
0
First Language
English
Primarily Uses
RMMV
Hi.

Was wondering if you fix an issue with the plugin when used alongside
Galv's MV Message Styles Plugin

Basically, once the script call activates during the end of the battle, the results window disappears.

Example:

I tested this out several times and I can assure you that it is an obvious compatibility issue between the two plugins.

I was just wondering if there is a chance that you might make this plugin compatible with Message Styles to get rid of this problem.
 

Tuomo L

Oldbie
Veteran
Joined
Aug 6, 2012
Messages
2,294
Reaction score
1,270
First Language
Finnish
Primarily Uses
RMMV
There's a bug ironically with Yanfly battle systems where after ATB battles, it will sometimes give you commands again while victory music is playing and the victory screen is displaying, I can still "attack" and do stuff sometimes. It doesn't happen every time but it does happen very often.
 

AdamSakuru

[Null_Value]
Veteran
Joined
Mar 14, 2014
Messages
314
Reaction score
170
First Language
English
Primarily Uses
N/A
Hi.

Was wondering if you fix an issue with the plugin when used alongside
Galv's MV Message Styles Plugin

Basically, once the script call activates during the end of the battle, the results window disappears.

Example:

I tested this out several times and I can assure you that it is an obvious compatibility issue between the two plugins.

I was just wondering if there is a chance that you might make this plugin compatible with Message Styles to get rid of this problem.
I second this, it's happening in my project and I'm not sure why.
 

AdamSakuru

[Null_Value]
Veteran
Joined
Mar 14, 2014
Messages
314
Reaction score
170
First Language
English
Primarily Uses
N/A
Guys, I paid Kino to fix the bug that AirTsunami mentioned. It's attached to this post as a patch. It fixes the bug when this plugin is used with Galv Message Styles.
 

Attachments

Last edited:

Galv

Veteran
Veteran
Joined
Oct 1, 2012
Messages
1,181
Reaction score
1,125
First Language
English
Primarily Uses
N/A
I'm not too happy about this. It would have been good if Kino wrote a patch plugin instead of modifying an old version of my Message Styles plugin file (with no information in the plugin itself that the file was modified by Kino) and now you are sharing it as if it were all my work :(

A patch is better because it will still work when I make updates in the future to my plugin. I'd be happy if you shared a patch with everyone but I'm not happy you sharing a modified old version plugin with no reference that Kino worked on it.
 
Last edited:

AdamSakuru

[Null_Value]
Veteran
Joined
Mar 14, 2014
Messages
314
Reaction score
170
First Language
English
Primarily Uses
N/A
I'm not too happy about this. It would have been good if Kino wrote a patch plugin instead of modifying an old version of my Message Styles plugin file (with no information in the plugin itself that the file was modified by Kino) and now you are sharing it as if it were all my work :(

A patch is better because it will still work when I make updates in the future to my plugin. I'd be happy if you shared a patch with everyone but I'm not happy you sharing a modified old version plugin with no reference that Kino worked on it.
Oh, I'm sorry. I didn't realize that was an issue. I did ask if Kino was fine with me uploading it. I should have checked with you too.

Would you like me to take it down? I re-uploaded the file in the post so that the filename had a reference to Kino's edit and I added some commented lines in the change log at the top to mention the date of the edit and what it is for.
 
Last edited:

Galv

Veteran
Veteran
Joined
Oct 1, 2012
Messages
1,181
Reaction score
1,125
First Language
English
Primarily Uses
N/A
Oh, I'm sorry. I didn't realize that was an issue. I did ask if Kino was fine with me uploading it. I should have checked with you too.

Would you like me to take it down? I re-uploaded the file in the post so that the filename had a reference to Kino's edit and I added some commented lines in the change log at the top to mention the date of the edit and what it is for.
That would be better, thank you for doing that. I do have updates I plan to make to my plugin, though, which won't be included in this file you are sharing.
 

AdamSakuru

[Null_Value]
Veteran
Joined
Mar 14, 2014
Messages
314
Reaction score
170
First Language
English
Primarily Uses
N/A
That would be better, thank you for doing that. I do have updates I plan to make to my plugin, though, which won't be included in this file you are sharing.
Cool, I actually just asked Kino about writing the plugin edit as a seperate patch, so I'll replace the file with the patch if that gets done.

Edit: Kino said the way she wrote it meant it wasn't done like a patch, but she said the edit was a very minor one. I told her to PM you what it is just so you knew why. I reverted the file back to the one I edited earlier.
 
Last edited:

Galv

Veteran
Veteran
Joined
Oct 1, 2012
Messages
1,181
Reaction score
1,125
First Language
English
Primarily Uses
N/A
Cool, I actually just asked Kino about writing the plugin edit as a seperate patch, so I'll replace the file with the patch if that gets done.

Edit: It's now a patch!
Just had a quick look at the file, I don't think you put the right one up there as it's not a patch it's the full plugin

EDIT: Disregard this as I noticed your last post edit that the file is not a patch.
 
Last edited:

phamtruong1992

Mage Art - Green Dragon
Veteran
Joined
Nov 22, 2015
Messages
164
Reaction score
196
First Language
English
Primarily Uses
RMMV
Thank you for this great plugin!!
 

NatuElChido

Rookie Dreamer
Veteran
Joined
Nov 13, 2017
Messages
33
Reaction score
4
First Language
Spanish
Primarily Uses
RMMV
Hey, do you still here?
 

Kes

Global Moderators
Global Mod
Joined
Aug 3, 2012
Messages
21,453
Reaction score
10,858
First Language
English
Primarily Uses
RMVXA
@NatuElChido DreamX has not visited the site for nearly a year.
 

J-G

Veteran
Veteran
Joined
Oct 4, 2019
Messages
319
Reaction score
61
First Language
English
Primarily Uses
RMMV
Seems cool but how do I download this plugin?
 

Users Who Are Viewing This Thread (Users: 0, Guests: 2)

Latest Threads

Latest Posts

Latest Profile Posts

Electro Swing--it's like swing--but with electros.
Is it wrong to look like a dead fish at all times :)
What worst could happen when your driver said "I know a shortcut"?
Creating Telekinesis script for another user, couldn't resist doing a scripted scene to display progress, when I could have just shown it in seconds XD

Forum statistics

Threads
93,629
Messages
914,116
Members
123,211
Latest member
nuwandw
Top