- Joined
- Mar 17, 2012
- Messages
- 1,149
- Reaction score
- 386
- First Language
- Sarcasm
- Primarily Uses
Scroll down to the red bolded text if you just want the fix.
Recently it was brought to my attention that when scrolling the map with a lot of events on screen, the events would "jump" by a single pixel and would be improperly positioned. I initially shrugged this off as lag, but when I saw the same effects on my absolutely awesome machine I wasn't quite sure what was up. I decided I would look into it a little bit more. When I tried to recreate it on my own by packing a screen full of events and then scrolling I was unable to reproduce the results. It wasn't until I tested the issue with the demo in a related topic that I noticed the issue seemed to have to do with slow speed panning.
Essentially what I discovered is that events and the tilemap were rounding extremely low values from "display_x" and "display_y" differently. The tilemap always rounded up while characters/events always rounded down. What do I mean by extremely low values? Because of the formula used to calculate scroll distance (2 ** @scroll_speed / 256.0) the display points can end up being values such as 15.5 pixels. As mentioned earlier, the tilemap would round this up to 16 while the events would round this down to 15. This would cause events to display 1 pixel away from where they were supposed to.
To fix the issue I modified two things to ensure that tilemaps and events would always get the same value. First of all I added two methods to replace the normal reader methods for the displays. In these I just multiplied by 32, used .floor to round down, switched it back to a floating point value, and divided it by 32. This ensured that when received by anything that might use the display values, it was always rounded to the lowest values without any further need for coercing. Secondly, I modified the two "adjust" methods used to determine the X and Y positions of events to reference the new reader methods rather than using the variable directly.
Anyway, all that done, here's the snippet. Be sure to place this under materials and above all additional custom scripts since this is meant to be a bugfix of the default scripts.
Pastebin link: http://pastebin.com/XDd0tVWJ
Full Script:
Recently it was brought to my attention that when scrolling the map with a lot of events on screen, the events would "jump" by a single pixel and would be improperly positioned. I initially shrugged this off as lag, but when I saw the same effects on my absolutely awesome machine I wasn't quite sure what was up. I decided I would look into it a little bit more. When I tried to recreate it on my own by packing a screen full of events and then scrolling I was unable to reproduce the results. It wasn't until I tested the issue with the demo in a related topic that I noticed the issue seemed to have to do with slow speed panning.
Essentially what I discovered is that events and the tilemap were rounding extremely low values from "display_x" and "display_y" differently. The tilemap always rounded up while characters/events always rounded down. What do I mean by extremely low values? Because of the formula used to calculate scroll distance (2 ** @scroll_speed / 256.0) the display points can end up being values such as 15.5 pixels. As mentioned earlier, the tilemap would round this up to 16 while the events would round this down to 15. This would cause events to display 1 pixel away from where they were supposed to.
To fix the issue I modified two things to ensure that tilemaps and events would always get the same value. First of all I added two methods to replace the normal reader methods for the displays. In these I just multiplied by 32, used .floor to round down, switched it back to a floating point value, and divided it by 32. This ensured that when received by anything that might use the display values, it was always rounded to the lowest values without any further need for coercing. Secondly, I modified the two "adjust" methods used to determine the X and Y positions of events to reference the new reader methods rather than using the variable directly.
Anyway, all that done, here's the snippet. Be sure to place this under materials and above all additional custom scripts since this is meant to be a bugfix of the default scripts.
Pastebin link: http://pastebin.com/XDd0tVWJ
Full Script:
Code:
##------## Display rounding error fix created by Neon Black.#### When certain slow display panning speeds are used, events will improperly## round floating values to determine their position on screen. This causes## them to appear off from the tilemap by a single pixel. Though minor this is## noticable. This snippet fixes this behaviour.#### This snippet may be used in any project.##------ class Game_Map ## Rounds X and Y display values DOWN so the nearest 32 is found. def display_x (@display_x * 32).floor.to_f / 32 end def display_y (@display_y * 32).floor.to_f / 32 end def adjust_x(x) if loop_horizontal? && x < display_x - (width - screen_tile_x) / 2 x - display_x + @map.width else x - display_x end end def adjust_y(y) if loop_vertical? && y < display_y - (height - screen_tile_y) / 2 y - display_y + @map.height else y - display_y end endend
Last edited by a moderator:
. good job neon 
