Status
Not open for further replies.

Eliaquim

Hakuen Studio
Veteran
Joined
May 22, 2018
Messages
2,028
Reaction score
1,504
First Language
Portuguese - Br
Primarily Uses
RMMZ
Hi there!
I'm making a plugin, and i have a doubt:

What is the best practice?
Code:
var _Elii_Game_Timer_update = Game_Timer.prototype.update;
    Game_Timer.prototype.update = function(sceneActive) {
        _Elii_Game_Timer_update.call(this, sceneActive);
                MY CODE STUFF HERE

or

Make my own function with the code and call it inside instead of putting the whle code.
Code:
var _Elii_Game_Timer_update = Game_Timer.prototype.update;
    Game_Timer.prototype.update = function(sceneActive) {
        _Elii_Game_Timer_update.call(this, sceneActive);
                $gameTimer.myFunction();

Or it is irrelevant?
 

Engr. Adiktuzmiko

Chemical Engineer, Game Developer, Using BlinkBoy'
Veteran
Joined
May 15, 2012
Messages
14,682
Reaction score
3,006
First Language
Tagalog
Primarily Uses
RMVXA
Unless you're gonna call that extra function from a different place or readying it for future aliasing/overwriting possibilities (that will only be for your custom added code lines not for the aliased function), I don't see much sense in doing it.
 

DrDhoom

Monkey Needs a Hug
Veteran
Joined
Mar 16, 2012
Messages
154
Reaction score
158
First Language
Indonesian
Primarily Uses
N/A
For update function I always create a new function, so that the update function won't be overcrowded and it'll be easier to find stuff because you'll know what the code is doing just based on the function name alone.
 

Poryg

Dark Lord of the Castle of Javascreeps
Veteran
Joined
Mar 23, 2017
Messages
4,134
Reaction score
10,669
First Language
Czech
Primarily Uses
RMMV
The first option is simpler, the second option is more readable. I myself prefer the first one.
 

MushroomCake28

KAMO Studio
Global Mod
Joined
Nov 18, 2015
Messages
3,932
Reaction score
4,845
First Language
EN, FR
Primarily Uses
RMMZ
I always do the first one, unless that extra bit of code will be called somewhere else.
 

waynee95

Inactive
Veteran
Joined
Jul 2, 2016
Messages
696
Reaction score
622
First Language
German
Primarily Uses
RMMV
I usually go with the first version, if the code is not really long.
 

Eliaquim

Hakuen Studio
Veteran
Joined
May 22, 2018
Messages
2,028
Reaction score
1,504
First Language
Portuguese - Br
Primarily Uses
RMMZ
Thank you for all the answers!! ^^
 

slimmmeiske2

Little Red Riding Hood
Global Mod
Joined
Sep 6, 2012
Messages
8,689
Reaction score
5,746
First Language
Dutch
Primarily Uses
RMXP

This thread is being closed, due to being solved. If for some reason you would like this thread re-opened, please report this post and leave a message why. Thank you.

 
Status
Not open for further replies.

Latest Threads

Latest Profile Posts

User of Mv3d/ Mz3d and Rosse engine. New Resource Pack on development "Halloween Stones" . Leave ideas about what you want to see on this package. :)
SetPreview.jpg
Looking at Code abd knowing that it made sense at one time. Ugh..why did I ever stop? Well I guess it will come back to me.
Well, Blizzard... thanks for making it easy to decide what to delete to free up some hard drive space... I guess. Ugh.
So far, I've rated 5 of the games out of the 120 submitted. Competition is fierce! There are a few which I played and thought "Well, at least my submission is better than this one." but there's at least one which is far better than mine (at least by my judgement.) Trying very hard to rate games fairly and only comment when I have something constructive to say. Good luck everyone!

Forum statistics

Threads
113,543
Messages
1,075,729
Members
147,542
Latest member
elsher
Top