Status
Not open for further replies.

Eliaquim

Hakuen Studio
Veteran
Joined
May 22, 2018
Messages
2,040
Reaction score
1,519
First Language
Portuguese - Br
Primarily Uses
RMMZ
Hi there!
I'm making a plugin, and i have a doubt:

What is the best practice?
Code:
var _Elii_Game_Timer_update = Game_Timer.prototype.update;
    Game_Timer.prototype.update = function(sceneActive) {
        _Elii_Game_Timer_update.call(this, sceneActive);
                MY CODE STUFF HERE

or

Make my own function with the code and call it inside instead of putting the whle code.
Code:
var _Elii_Game_Timer_update = Game_Timer.prototype.update;
    Game_Timer.prototype.update = function(sceneActive) {
        _Elii_Game_Timer_update.call(this, sceneActive);
                $gameTimer.myFunction();

Or it is irrelevant?
 

Engr. Adiktuzmiko

Chemical Engineer, Game Developer, Using BlinkBoy'
Veteran
Joined
May 15, 2012
Messages
14,682
Reaction score
3,006
First Language
Tagalog
Primarily Uses
RMVXA
Unless you're gonna call that extra function from a different place or readying it for future aliasing/overwriting possibilities (that will only be for your custom added code lines not for the aliased function), I don't see much sense in doing it.
 

DrDhoom

Monkey Needs a Hug
Veteran
Joined
Mar 16, 2012
Messages
154
Reaction score
158
First Language
Indonesian
Primarily Uses
N/A
For update function I always create a new function, so that the update function won't be overcrowded and it'll be easier to find stuff because you'll know what the code is doing just based on the function name alone.
 

Poryg

Dark Lord of the Castle of Javascreeps
Veteran
Joined
Mar 23, 2017
Messages
4,136
Reaction score
10,674
First Language
Czech
Primarily Uses
RMMV
The first option is simpler, the second option is more readable. I myself prefer the first one.
 

MushroomCake28

KAMO Studio
Global Mod
Joined
Nov 18, 2015
Messages
3,934
Reaction score
4,847
First Language
EN, FR
Primarily Uses
RMMZ
I always do the first one, unless that extra bit of code will be called somewhere else.
 

waynee95

Inactive
Veteran
Joined
Jul 2, 2016
Messages
696
Reaction score
622
First Language
German
Primarily Uses
RMMV
I usually go with the first version, if the code is not really long.
 

Eliaquim

Hakuen Studio
Veteran
Joined
May 22, 2018
Messages
2,040
Reaction score
1,519
First Language
Portuguese - Br
Primarily Uses
RMMZ
Thank you for all the answers!! ^^
 

slimmmeiske2

Little Red Riding Hood
Global Mod
Joined
Sep 6, 2012
Messages
8,727
Reaction score
5,760
First Language
Dutch
Primarily Uses
RMXP

This thread is being closed, due to being solved. If for some reason you would like this thread re-opened, please report this post and leave a message why. Thank you.

 
Status
Not open for further replies.

Latest Threads

Latest Posts

Latest Profile Posts

Frustrated, as always. I took a break from working on games and when I turned back to working on them again, bam! Slapped in the face with more errors. Such is the pain of working on any project, I suppose.
Checking out the Judge's Round Table. Really cool getting their perspective in a Q/A environment like this.
I'm heading back to Orlando tomorrow! Dad said he's going to take me to my favorite arcade and maybe Aquatica.
animated message windows <3
or message window that uses background images that can be animated?
Still need to fix some things, but it's going great so far :)
CEPjLJn.gif
just when I thought one of the greatest game of all time couldn't get any better, they announce a new dlc for it.

Forum statistics

Threads
113,788
Messages
1,077,467
Members
147,823
Latest member
neah
Top