Incompatibility between Jay's Dualtechs and YEP SkillLearnSystem?

[Songsmith]

As the title states, I'm using the plugins jay_dualtechs and YEP_SkillLearnSystem, found here and here.

Dualtech - https://forums.rpgmakerweb.com/index.php?threads/jays-dual-tech-system-version-1-1-2b.47765/

SkillLearn - http://yanfly.moe/2015/11/14/yep-28-skill-learn-system/

Using the Dual Techs in battles works fine, but when I try to open the Skill scene from the Menu, the game crashes. When I turn off the YEP SkillLearnSystem, everything works fine.

It makes even less sense because I have the "Integrate Learn Skills into the Skill Scene" option turned off for the SkillLearnSystem plugin, so I don't see why it should be interacting with it at all. I also tried putting one plugin below the other, and vice-versa. No effect.

Here is a screenshot of the console error.

And here is a screenshot of the first line of code where the error appears from Jay's plugin...

And Yanfly's plugin.

Any way to make these compatible? Is there just something I'm doing wrong? If you need any more information/screenshots, just ask and I'd be happy to provide.

 

[Trihan]

The only reason I can see for this to be happening is that dualParams[i+1] doesn't contain any names that match elements in $dataSkills, because then the filter would result in an empty array and subsequently the 0th element wouldn't exist.

 

[Songsmith]

So the DualTech plugin isn't getting the correct parameters?

Here is the notetag for the skill in question (the only Dual skill the actors have right now, when the error is happening).

<Dual:1,52,2,5>

and this is how the dualtech plugin says to define parameters in the plugin help text.

"A dualtech skill should have the following tag in its note box:

<Dual:ID1,Skill1,ID2,Skill2,ID3,...,HitRate>

ID1 is the character ID of one of the characters involved.
Skill1 is the skill required for that character, either as an ID or skill name.
ID2 and Skill2 likewise refer to the second character. You can include up
to 10 characters with skills."

Actors 1 and 2 are the current actors I'm using, and skills 52 and 5 are skills that each respective actor has.

 

[Trihan]

The weird thing is that if you're not using the skill name, it shouldn't even be hitting that line in the first place because it should end up in the else.

Do you still get a crash if you take out the dual skill notetag but keep both plugins on?

 

[Songsmith]

I just tried that and strangely, yes. I get the same error.

 

[Trihan]

Okay, so it's nothing to do with the notetags themselves, that's getting us somewhere.

Edit: How many notetags did you have when you first tried this?

 

[Songsmith]

Just the one notetag, on the one Dual skill.

 

[Trihan]

Edit: Never mind, I think I may have misunderstood how the dualParams work. Still trying to figure out what might be causing this.

Have you done any other customisation of either plugin?

 

[Songsmith]

I don't quite get it. The notetag I have is on the Dual Skill itself, not on the characters. Both characters have the Dual skill, and then each character has the particular skill that is required for the dual skill to work. I need to put
notetags on the actors?

 

[Trihan]

No, the tags do go on the skill. I hadn't read the plugin description.

 

[Songsmith]

Thank you for trying, anyway. Let me know if you get any epiphanies, haha.

 

[HeroicJay]

Okay, my plugin is one of the ones involved here. Let me take a crack at this.

The first thing I should point out is that I use Yanfly's Skill Learn System plugin in my main project, and of course the Dualtech plugin as well (my plugins are made for my own purposes first) and have no problem. I haven't updated my Yanfly plugins in a while, but I have no idea why that would make a difference in this case. EDIT: Updated Skill Learn System to Yanfly's latest; no repro as of yet.

A little more information would help:

1. Which plugin is listed first in your Plugins window: Skill Learn System or Dualtechs? (For me, Skill Learn is first.)

2. Is the Dualtech listed as a skill you can learn from the Skill Learn system? (For me, the answer is no.) EDIT: Made "Fire Power" dualtech a learnable skill instead of one automatically added. No repro. Whether Carol (the second party member, and not the one learning the skill) was present in the party had no bearing; skill was learnable and even displayed correctly, though due to the nature of the Dualtech plugin, skill was of course not available when Carol was not in the party after being learned.)

EDIT: Just noticed you had skill learn system integration turned off. Haven't tried that. Lemme see what happens. FURTHER EDIT: Nope. And apparently the integration doesn't do what I thought it did anyway.

FINAL EDIT FOR NOW: Sorry, I'm so far unable to reproduce this issue at all. There's more I could try, but it's late and I'm sleepy; I'll hammer on it later.

One last thought for the night is that maybe a space snuck into your Dual tag? I forget how Javascript handles that, but probably not well. But it's not listed when you wrote what you had in the tag, and you said you see the issue event when you remove the tag, so that's probably not it; just a guess. If you can zip up a copy of a project that has the bug (just make a new project, make the bug happen, and remove all data files) I can look at it when I have the time.

 

[Songsmith]

Thanks for all the effort Jay! I won't be able to work much on it this week, but I'll attempt to get a barebones project with the bug for you by this weekend.

 

[Songsmith]

Hey @HeroicJay ! I am both happy and disappointed to tell you that I am no longer having the issue, but I really don't know why. I didn't work on the project much this week, but upon booting it up today I am no longer having the issue. I changed several things, most of which I thought were unrelated, so I'm still not quite sure what the issue was. Thank you for your work and replies on it though, and again, thank you for your wonderfully useful plugin.

EDIT: I just realized it's possible that I had one of the <Dual> plugin tags pointing to a character that wasn't in the party. I recently had changed which actors were in the party, so that could be a likely culprit of my issue.

 

[HeroicJay]

I just realized it's possible that I had one of the <Dual> plugin tags pointing to a character that wasn't in the party. I recently had changed which actors were in the party, so that could be a likely culprit of my issue.

Doubt it, unless you shrunk the character database so that the character's ID didn't exist any more (and even then, it seems like a weird error). The Dualtech plugin is specifically designed to pay attention to who is and isn't in the party, and it just hides the skills when one of the users isn't available.

But good to know that the problem is fixed.