LGP - Better Damage Popup

Discussion in 'JS Plugin Releases (RMMV)' started by Azel, Jul 14, 2018.

  1. gambitben

    gambitben Veteran Veteran

    Messages:
    135
    Likes Received:
    97
    First Language:
    Spanish English
    Primarily Uses:
    RMMV
    I don't know why but I seem unable to make the pop ups work... it just looks like the normal thing, it doens't even change the font. I used to be able to use your 1.2 version and it worked wonders. Do I have to write something inside the code for it to show the popups?

    PS: I don't really know javascript, if the code is required for the pop ups to show, could you post the basic outline for each? Thank you very much, your plugins are amazing.
     
    #21
  2. Azel

    Azel Seeker Veteran

    Messages:
    31
    Likes Received:
    44
    Location:
    Swiss
    First Language:
    German
    Primarily Uses:
    RMMV
    Do a filter on the addedStates array inside the drawState Parameter. Just copy all code from the function drawDefaultState and copy it inside the "Draw State Popup Code" parameter's note box.

    Code:
    addedStates = addedStates.filter(function(state){
       if (state.id === 4) {
           return state;
       }
    });
    
    Then past this code somewhere below "var addedStates = result.addedStateObjects();" and above the "for( ; ; )" loop.
     
    Last edited: Aug 13, 2018
    #22
    Zinnherz likes this.
  3. Azel

    Azel Seeker Veteran

    Messages:
    31
    Likes Received:
    44
    Location:
    Swiss
    First Language:
    German
    Primarily Uses:
    RMMV
    Sorry for the inconvenience!

    Since 1.2 worked on your end, it should work for the current one. Remove the plugin from your Plugin Manager. After applying the changes select the plugin again and put it somewhere below the required plugins.

    If this didn't work then my code might caused an error with another one (open the debugger, then you should see it better). If you see something along the lines of "DRAW CUSTOM BLA BLA POPUP ERROR". and then bunch of red text, screenshot it and send it to me. I can fix the problem. Although you can try to delete all custom code inside the plugin parameters by yourself. This might temporary solve your problem.

    To your last thing. Coding isn't needed. Everything is already done and setup. It should immediately work like the older version.

    if nothing helped. Reach out for me.
     
    #23
    gambitben likes this.
  4. Zinnherz

    Zinnherz Villager Member

    Messages:
    20
    Likes Received:
    3
    First Language:
    German
    Primarily Uses:
    RMMV
    Thank you for the quick reply, it took me a while to get it to work since I'm a noob with Javascript, but I got it after using the code from drawDefaultState instead of drawDefaultBuff.
    Thanks again, works like a charm now! :D It's perfect.
     
    #24
  5. Azel

    Azel Seeker Veteran

    Messages:
    31
    Likes Received:
    44
    Location:
    Swiss
    First Language:
    German
    Primarily Uses:
    RMMV
    Oh crap. How did I not see this. I'm a genius at this. Welp. You still got it though. Happy it worked.
     
    #25
  6. gambitben

    gambitben Veteran Veteran

    Messages:
    135
    Likes Received:
    97
    First Language:
    Spanish English
    Primarily Uses:
    RMMV
    I tried it in a new project and still doesn't work for me. I took a screenshot of the console, but I can't upload it now cause the server is giving me an error, so in the mean time: it says SyntaxError: unexpected token ) in line 1056. Hope it helps, thank you.

    Image here:
    [​IMG]

    [​IMG]
     
    Last edited: Aug 14, 2018
    #26
  7. Jrrkein

    Jrrkein Insert Witty Title Here Veteran

    Messages:
    131
    Likes Received:
    17
    First Language:
    Indonesia
    Primarily Uses:
    RMMV
    @Azel : I think it's broken, I can't see the damage popup anymore and just boring bouncing damage pop up
     
    #27
  8. Azel

    Azel Seeker Veteran

    Messages:
    31
    Likes Received:
    44
    Location:
    Swiss
    First Language:
    German
    Primarily Uses:
    RMMV
    Read the red text on the first thread good sir. I just added it. Version 1.2 used to have variables that no longer belong in version 1.3. If its broken, press f8 during battle test and read the text for me. Then we might have a real error.
     
    #28
  9. Jrrkein

    Jrrkein Insert Witty Title Here Veteran

    Messages:
    131
    Likes Received:
    17
    First Language:
    Indonesia
    Primarily Uses:
    RMMV
    @Azel:
    /C:/Users/sony/Documents/Games/NINJA%20GO/js/plugins/LGP_BetterDamagePopup.js:1056 Uncaught SyntaxError: Unexpected token )
     
    #29
  10. Azel

    Azel Seeker Veteran

    Messages:
    31
    Likes Received:
    44
    Location:
    Swiss
    First Language:
    German
    Primarily Uses:
    RMMV
    Well. Look at that!
    Code:
    bitmap.drawText(string, 0, 0, w, h,);
    
    I fixed the problem. Thanks for help.
    Why didn't I get an error, this puzzles me the most.
     
    #30
  11. Jrrkein

    Jrrkein Insert Witty Title Here Veteran

    Messages:
    131
    Likes Received:
    17
    First Language:
    Indonesia
    Primarily Uses:
    RMMV
    Uncaught SyntaxError: Unexpected token )
     
    #31
  12. Azel

    Azel Seeker Veteran

    Messages:
    31
    Likes Received:
    44
    Location:
    Swiss
    First Language:
    German
    Primarily Uses:
    RMMV
    Yep. found another one. Please download it again. If you get another error, I'll go mental.
    Why does it work on my game? This puzzles me the most.
    Welp. There goes my reputation.
     
    Last edited: Aug 15, 2018
    #32
  13. Jrrkein

    Jrrkein Insert Witty Title Here Veteran

    Messages:
    131
    Likes Received:
    17
    First Language:
    Indonesia
    Primarily Uses:
    RMMV
    The error is gone and no longer showing in the node.js
     
    #33
  14. Azel

    Azel Seeker Veteran

    Messages:
    31
    Likes Received:
    44
    Location:
    Swiss
    First Language:
    German
    Primarily Uses:
    RMMV
    Great. Should work as intended now. Have fun and sorry for the trouble.
     
    #34
    gambitben likes this.
  15. SoSick.

    SoSick. Veteran Veteran

    Messages:
    223
    Likes Received:
    190
    Location:
    UK
    First Language:
    english
    Primarily Uses:
    RMMV
    plugin is great @Azel thank you so much! :D
     
    #35
  16. Gregaur

    Gregaur Veteran Veteran

    Messages:
    89
    Likes Received:
    11
    First Language:
    french
    Hi Azel,

    Your pluggin seems to be great, but doesn't work for me :

    I download the 1.4 directly. The states pop-up and Miss pop-up work but not the damage pop up. Even the vanilla one don't show up anymore

    I have nothing in the developer tools... Kind of odd...

    Thanks a lot for your work anyway !

    Greg
     
    #36
  17. Azel

    Azel Seeker Veteran

    Messages:
    31
    Likes Received:
    44
    Location:
    Swiss
    First Language:
    German
    Primarily Uses:
    RMMV
    I assume you...
    ...never had a previous version of my plugin in your game.
    ...saw no error in the debugger.

    It's kind off odd indeed. All I can think off right now is that another plugin changed the behavior of some "Battler" or "ActionResult" code that are only being used by the damage numbers.

    Try to deactivate all plugins besides the few ones that are required to run LGP_BetterDamagePopup and test it again.
     
    #37
  18. Gregaur

    Gregaur Veteran Veteran

    Messages:
    89
    Likes Received:
    11
    First Language:
    french
    Indeed it was the first installation.

    So I tried to deactivate everythings except the few needed. But still nothing. State and miss pop up work but not the numbers...

    That sad, it would be a great feature in my game...
     
    #38
  19. Azel

    Azel Seeker Veteran

    Messages:
    31
    Likes Received:
    44
    Location:
    Swiss
    First Language:
    German
    Primarily Uses:
    RMMV
    Let me help you. I might learn something. Let's start a conversation.
     
    #39
  20. Zinnherz

    Zinnherz Villager Member

    Messages:
    20
    Likes Received:
    3
    First Language:
    German
    Primarily Uses:
    RMMV
    I just noticed something; when buffing my characters, the buff shows as intended (icon and name), but when debuffing an enemy, it only shows the icon without the name of the affected stat.

    While this isn't an issue, I was just wondering if this was the way you intended it to be, or if there was something missed. (Or maybe I messed someting up on my end. *shrug*)
     
    #40

Share This Page