Ludo Position Logger Plugin Crashing

[frdbrick]

Hi All,

So the Ludo Position Logger, which can be found here. Tracks players movements and then exports the file to a txt file. I have modified this script to track other movement and data choice selections. See spoiler below to see my edits. For the most part this plugin works great. I can play the game, save it, and then when I return to the title screen a txt file is exported to my save folder. If I think directly click continue I can continue playing the game and then save again. The issue comes when I close my game window completely, and then restart RPG Maker MV. If I restart it and then click continue, I get an error (see attached image below). It essentially says that pathing is undefined. I'm not sure why pathing is defined when I first play the game, and when I hit continue without closing...but once I close the game and restart it, it doesn't work. Any help with this would be greatly appreciated! I have been pulling what little hair have left out.

Spoiler: My Edits

$testing = [];
$defaultSwitchId = Number(PluginManager.parameters("LudoSavePathing")["Default SwitchId"]) || 20;
$msaves = Number(PluginManager.parameters("LudoSavePathing")["Max Saves"]) || 20;
$titlesave = (PluginManager.parameters("LudoSavePathing")["Save on Title Screen"] == "true");

Scene_Map.prototype.onMapLoaded = function() {
if (this._transfer) {
$gamePlayer.performTransfer();
}

this.createDisplayObjects();
};


//=============================================================================
// Collecting Pathing Information
//=============================================================================
Game_Player.prototype.increaseSteps = function() {
Game_Character.prototype.increaseSteps.call(this);
if (this.isNormal()) {
$gameParty.increaseSteps();
if($msaves > 0 && $dataMap.meta.Track){
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Path", this._x, this._y]);
}
}
};

//=============================================================================
// Menu Access
Scene_Map.prototype.callMenu = function() {
SoundManager.playOk();
SceneManager.push(Scene_Menu);
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Menu On"]);
Window_MenuCommand.initCommandPosition();
$gameTemp.clearDestination();
this._mapNameWindow.hide();
this._waitCount = 2;
};

Scene_Menu.prototype.commandItem = function() {
SceneManager.push(Scene_Item);
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Item"]);
};

Scene_Skill.prototype.createSkillTypeWindow = function() {
var wy = this._helpWindow.height;
this._skillTypeWindow = new Window_SkillType(0, wy);
this._skillTypeWindow.setHelpWindow(this._helpWindow);
this._skillTypeWindow.setHandler('skill', this.commandSkill.bind(this));
this._skillTypeWindow.setHandler('cancel', this.popScene.bind(this));
this._skillTypeWindow.setHandler('pagedown', this.nextActor.bind(this));
this._skillTypeWindow.setHandler('pageup', this.previousActor.bind(this));
this.addWindow(this._skillTypeWindow);
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Skill"]);
};

Scene_Status.prototype.create = function() {
Scene_MenuBase.prototype.create.call(this);
this._statusWindow = new Window_Status();
this._statusWindow.setHandler('cancel', this.popScene.bind(this));
this._statusWindow.setHandler('pagedown', this.nextActor.bind(this));
this._statusWindow.setHandler('pageup', this.previousActor.bind(this));
this._statusWindow.reserveFaceImages();
this.addWindow(this._statusWindow);
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Status"]);
};
//=============================================================================
// Timestamps for Using/selecting Items,armor,weapons
//=============================================================================

Scene_ItemBase.prototype.useItem = function() {
this.playSeForItem();
this.user().useItem(this.item());
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Use_Item" ,this.item().name]);
this.applyItem();
this.checkCommonEvent();
this.checkGameover();
this._actorWindow.refresh();
};

Scene_ItemBase.prototype.showSubWindow = function(window) {
window.x = this.isCursorLeft() ? Graphics.boxWidth - window.width : 0;
window.show();
window.activate();
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Select_Item" ,this.item().name]);
};


Scene_Equip.prototype.onItemOk = function() {
SoundManager.playEquip();
this.actor().changeEquip(this._slotWindow.index(), this._itemWindow.item());
this._slotWindow.activate();
this._slotWindow.refresh();
this._itemWindow.deselect();
this._itemWindow.refresh();
this._statusWindow.refresh();
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Equip_Item" ,this.item().name]);
};



//$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Menu Off"]);

//=============================================================================
// Collects All EVent Info
//=============================================================================
Game_Player.prototype.startMapEvent = function(x, y, triggers, normal) {
if (!$gameMap.isEventRunning()) {
$gameMap.eventsXy(x, y).forEach(function(event) {
if (event.isTriggerIn(triggers) && event.isNormalPriority() === normal) {
event.start();
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Event_Start",event.event().name]);
}
});
}
};
//=============================================================================
// Battle Start and Stop Times
//=============================================================================
BattleManager.setup = function(troopId, canEscape, canLose) {
this.initMembers();
this._canEscape = canEscape;
this._canLose = canLose;
$gameTroop.setup(troopId);
$gameScreen.onBattleStart();
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Battle_Start",troopId]);
this.makeEscapeRatio();
};

BattleManager.endBattle = function(result) {
this._phase = 'battleEnd';
if (this._eventCallback) {
this._eventCallback(result);
}
if (result === 0) {
$gameSystem.onBattleWin();
} else if (this._escaped) {
$gameSystem.onBattleEscape();
}
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Battle_End", result]);
};

//=============================================================================
// All Text Info and Choices (n = choices, 0 is first choice)
//=============================================================================
Game_Message.prototype.allText = function() {
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(), "Text", this._texts]);
return this._texts.join('\n');
};

Game_Message.prototype.onChoice = function(n) {
if (this._choiceCallback) {
this._choiceCallback(n);
$testing.filter(function(test){ return test.id === $gameMap._mapId })[0].pathing.push([$gameSystem.playtimeText(),"Respond", this._choices,n]);
this._choiceCallback = null;
}
};

//=============================================================================
// Map Transfer Info
//=============================================================================
Game_Player.prototype.performTransfer = function() {
if (this.isTransferring()) {
this.setDirection(this._newDirection);
if (this._newMapId !== $gameMap.mapId() || this._needsMapReload) {
$gameMap.setup(this._newMapId);
this._needsMapReload = false;
}
this.locate(this._newX, this._newY);
if($dataMap.meta.Track && $msaves > 0){
console.log("runs");
var Ludoexample = $testing.filter(function(test){ return test.id === $gameMap._mapId });
if(Ludoexample.length == 0){
var b = {
id : this._newMapId,
pathing : [[$gameSystem.playtimeText(), "Transfer", this._newX,this._newY]],
}
$testing.push(b);
}
else Ludoexample[0].pathing.push([$gameSystem.playtimeText(), "Transfer", this._newX, this._newY]);
}

this.refresh();
this.clearTransferInfo();
}
};

Game_Switches.prototype.onChange = function() {
$gameMap.requestRefresh();
Game_Switches.saveFile(this._data[$defaultSwitchId]);
};

Game_Switches.saveFile = function(sw) {
if($msaves > 0 && sw){
console.log("Outputting file");
json = "";
$testing.forEach(function(element){
json += "{\n";
json += "\t" + '"Map_id" : "' + element.id + '",\n';
json += "{\t" + '"Pathing" : ' + '[\n';
element.pathing.forEach(function(array){
if(element.pathing.indexOf(array) == element.pathing.length-1){
json += "\t\t[" + '"' + array[0] + '"' + ", " + array[1] + ", " + array[2] + "," + array[3] + "]";
}
else json += "\t\t[" + '"' + array[0] + '"' + ", " + array[1] + ", " + array[2] + "," + array[3] + "],\n";
});
json += '\n\t]\n';
json += "}";
json += "\n";
});

StorageManager.saveToTestFile(json);

$msaves--;
}
}

StorageManager.saveToTestFile = function(json) {
var fs = require('fs');
var dirPath = this.localFileDirectoryPath();
var ref = Number(PluginManager.parameters("LudoSavePathing")["Max Saves"]) - $msaves + 1;
var playername = $gameActors.actor(1).name();
var filePath = this.localFileDirectoryPath() + playername + ref + ".txt";
if (!fs.existsSync(dirPath)) {
fs.mkdirSync(dirPath);
}
fs.writeFileSync(filePath, json);
};

Scene_GameEnd.prototype.commandToTitle = function() {
if($titlesave) Game_Switches.saveFile(true);
Scene_GameEnd.clearTrackInfo();
this.fadeOutAll();
SceneManager.goto(Scene_Title);
};

Scene_Gameover.prototype.gotoTitle = function() {
if($titlesave) Game_Switches.saveFile(true);
Scene_GameEndne.clearTrackInfo();
SceneManager.goto(Scene_Title);
};

Scene_GameEnd.clearTrackInfo = function(){
for(var i of $testing){
i.pathing = [];
}
}

 

[caethyril]

I think it may be because the plugin only initialises the pathing property on transfer. DataManager.setupNewGame invokes a player transfer to move the player to the starting position, but DataManager.loadGame only invokes a transfer if the game has been updated since the save was made. An override like this may work?

Scene_Load.prototype.reloadMapIfUpdated = function() {
	$gamePlayer.reserveTransfer($gameMap.mapId(), $gamePlayer.x, $gamePlayer.y);
	$gamePlayer.requestMapReload();
};

All I've done is remove the version check for transfer, hopefully that fixes it.

 

[frdbrick]

I think it may be because the plugin only initialises the pathing property on transfer. DataManager.setupNewGame invokes a player transfer to move the player to the starting position, but DataManager.loadGame only invokes a transfer if the game has been updated since the save was made. An override like this may work?

Scene_Load.prototype.reloadMapIfUpdated = function() {
    $gamePlayer.reserveTransfer($gameMap.mapId(), $gamePlayer.x, $gamePlayer.y);
    $gamePlayer.requestMapReload();
};

All I've done is remove the version check for transfer, hopefully that fixes it.

OMG! You have saved my bacon! Thank you so much! I knew there was an issue with the transfer...but no idea how to fix it... I spent 6 hours staring at that damn code yesterday.