RMMZ [MZ & MV v1.9.1] Shora Lighting & Shadow System

[Shora]

Hye for some reason one of my lights suddenly stopped working post update. Specifically [light fire].

I haven't made any other changes and regular [light] is fine.


ANyone else get that post update?


EDIT: it seems they are all using the same light image (specifically torch form the demo project) At game start the light shows for like half a second and then disappears. Not happening with any other image tho

I belive the disappear issue is from the old default pulse factor setting of the custom lighting is 1, but now it being 100-scale which mean it will shrink into 1% radius. I'm working on fixing this but for the time being you could go to the plugin manager and set it to 100 instead of 1. But I thought all the custom light have their pulse setting off by default.. So how did this even happen? Can you make me a quick demo illustrating the problem?

Also the [light fire] template is depracted, and you may want to use [fire] instead. If you use [light fire + parameters] it will not work, but [fire -r 120] for example is.

 

[Puppet Knight]

Also the [light fire] template is depracted, and you may want to use [fire] instead. If you use [light fire + parameters] it will not work, but [fire -r 120] for example is.

didnt realize I could do this. So much easier thanks.

I'm working on fixing this but for the time being you could go to the plugin manager and set it to 100 instead of 1

This was the issue. Just have to adjust where needed now. Personally I think the 100% value makes more sense.


All good now


EDIT: Played around with diff percentages for pulse. Please keep it a % lol. So much more intuitive. Just maybe note in the parameter that it's a 100% where needed

 

[Dark_Ansem]

Amazing new update, and it seems so much more intuitive.

 

[Puppet Knight]

One add in ask that I would make if you do keep the % for the Advanced animation section:


Have the percentages be of the total size set by the radius of that light. Not the percentage of the original image size.

For example:

If i set the pulse to 50% while the radius was already set to 60. It should be pulsing between 30-60 radius. Just more user friendly and less math for us to figure out if this is possible to set up that way

 

[Shora]

One add in ask that I would make if you do keep the % for the Advanced animation section:


Have the percentages be of the total size set by the radius of that light. Not the percentage of the original image size.

For example:

If i set the pulse to 50% while the radius was already set to 60. It should be pulsing between 30-60 radius. Just more user friendly and less math for us to figure out if this is possible to set up that way

Have it the percentage of radius seem good. For example light with 60 radius and pulse factor of 20% will be between 48-72, like 80% original radius to 120% original radius. I will add it in the next update.

 

[Puppet Knight]

Have it the percentage of radius seem good. For example light with 60 radius and pulse factor of 20% will be between 48-72, like 80% original radius to 120% original radius. I will add it in the next update.

This brought me more questions actually. For clarity, what exactly does pulse factor mean for your plugin as it relates to the radius of the light.

I guess what would be good would be a breakdown of the different terms you use in the plugin parameters (and then add that to the help or quick start guide?)


Also a tiny note:



says flick animation instead of pulse for the Pulse factor

 

[Shora]

Update v.1.9.1 (6/6/2023):
Download from itch.io page: https://shoraaa.itch.io/shora-lighting-plugin

- Major optimization, mainly for MV version. Up from 2fps to ~50fps in 100 light 500 shadow benchmark.
Before:


After:


MZ FPS stay the same though.. Maybe it already good enough.

- Change the pulse factor defination. Now it is the difference of original light radius. For example: Light with original radius 60 with pulse factor 25% will have their radius ranging from 60 - 60*25% to 60 + 60*25%, which is 45 to 75.

- Add a way to temporary disable the plugin on specific map. Just add [lighting off] to the map notetags instead of using event.

- Fix some minor bugs.

P/s: My plugin/scripting commision is opened! If you have any interests, you can check it here!

 

[Puppet Knight]

Change the pulse factor defination. Now it is the difference of original light radius. For example: Light with original radius 60 with pulse factor 25% will have their radius ranging from 60 - 60*25% to 60 + 60*25%, which is 45 to 75.

Hey, I would say for the pulse to name it a Pulse Range vs a % if this is the way its handled.


The percentage I was suggesting was more along the lines of:

Radius = 60
Pulse = 25%

This would mean the pulse should go from a range of 45(60*.25) -> 60


I like your way better. But "%" wouldn't be the accurate term in that scenario. Range would. (Technically "variance" would be best but Range is fine)


With this really intuitive update it would be great to be able to set the pulse for an individual event via comment (not sure if you can already) and/or plugin command in the set light parameters command

 

[Shora]

Hey, I would say for the pulse to name it a Pulse Range vs a % if this is the way its handled.


The percentage I was suggesting was more along the lines of:

Radius = 60
Pulse = 25%

This would mean the pulse should go from a range of 45(60*.25) -> 60


I like your way better. But "%" wouldn't be the accurate term in that scenario. Range would.


With this really intuitive update it would be great to be able to set the pulse for an individual event via comment (not sure if you can already) and/or plugin command in the set light parameters command

I have it like that to make the old default setting (1) worked without any need to rechange. The factor 1 will make it to pulse between 99-101, instead of shrink to 1% like before . Thanks for the name change suggestion! I will change it in the next update

 

[twosnakes]

Latest version is finally giving me stellar performance, awesome work Shora! Still some stutter, but likely related to all my other plugins and stuff going on. Any prospects for even more optimization in MV?

Also would there be a way to use Terrain Tags instead of region ids?

 

[Shora]

Latest version is finally giving me stellar performance, awesome work Shora! Still some stutter, but likely related to all my other plugins and stuff going on. Any prospects for even more optimization in MV?

More optimizations are definitely comming, for both version. MV will always be a little slower than MZ though, mainly because of engine improvement.

Also would there be a way to use Terrain Tags instead of region ids?

That.. is such a good suggestion! I never used terrain tags before, so I literally forgot it even existed. I'm playing around with it, and given the following terrain tags used:
It already give a pretty good scene, without the need to use any region id!



There are some visual bugs that need to be fixed, but it already pretty promising. Thank for the suggestion! This will be pushed in the next update, that will retained both the old region id way and the newer, more automatic terrain tags way

 

[Dark_Ansem]

I literally forgot it even existed

This happens to me as well, way too often.

 

[DK]

I think I found a bug: $shoraLayer.updateColorFilter is not a function

Spoiler

I'm trying to add plugin compatibility to my time plugin. What is the best way to control lighting? Through the $gameLighting.setMapAmbient function?

 

[Shora]

I think I found a bug: $shoraLayer.updateColorFilter is not a function

Spoiler

View attachment 265406

I'm trying to add plugin compatibility to my time plugin. What is the best way to control lighting? Through the $gameLighting.setMapAmbient function?

Thank you for your report. It should be ```
updateIntensityFilter``` but I forgot to change it. Fixed in next update.

You can use the $gameLighting.setMapAmbient function to manually create a simple time system, just remember to call it only once. If you want more control, you can directly set the $shoraLayer._ambient.tint value to your hex color.

 

[VectorHeavens]

Heya, amazing plugin! Huge fan of the capabilities and workflow, and perhaps most importantly, the code is super readable. Fantastic work!

Out of curiosity - it seems unlikely as it seems it'd require a significant changes (and constant updates) to caster generation, but is there any possibility for consideration of light height as well as wall height? For example, when the player stands next to a cliff, their light doesn't reach the top, but if they climb it via ladder, the new reference height becomes the cliff's region. It feels like this kind of approach wouldn't work with terrain tags though, but perhaps a property on the light itself might be used instead to determine its height in the fake 3D space.

It seems this type of thing would tank performance pretty heavily, as you'd have to generate shadow casters individually for every layer of height, but maybe I'm misunderstanding how it functions so I figure I might as well ask.

 

[makaro46]

Thanks for the great plugin.

I wanted to create a flashlight on/off system and created a common event with the sample.
However, when I turn the light status OFF in the script, it never turns ON again.

I'm using the latest plugin and I've tried the demo but I'm getting the same problem.

 

[untamedeventuality]

Hey, I'm having trouble figuring out all the ins and outs of your plugin. I want to have my game start out in the sort of basic rpg maker lighting mode (everything being lit) and then at a later point in the game have the light-source be attached to the player character (the sun has gone down/power's gone out). Is there a way for me to do this?
Also, I might be having a bug where I can't have multiple light sources at once.

 

[LyraVultur]

in the Plugin Manager (puzzle piece or F10), find and double-click -Shora Lighting-, then double-click the [Map: Default] setting, then double-click the [Default: Ambient] setting. Change the hex color code (default is #232323, pretty dark) to completely bright (#ffffff). Now your game should default to the normal lighting.
When you want it to be dark again, call a Plugin Command in an event. Find Shora Lighting and use "Set Map Ambient" to change the lighting back to a dark colour.

 

[untamedeventuality]

View attachment 269344
in the Plugin Manager (puzzle piece or F10), find and double-click -Shora Lighting-, then double-click the [Map: Default] setting, then double-click the [Default: Ambient] setting. Change the hex color code (default is #232323, pretty dark) to completely bright (#ffffff). Now your game should default to the normal lighting.
When you want it to be dark again, call a Plugin Command in an event. Find Shora Lighting and use "Set Map Ambient" to change the lighting back to a dark colour.

Awesome, thank you so much! That totally worked!
New problem, I can't get the Set Light Parameters to work right. Can't figure out if its a bug or operator error...

 

[LyraVultur]

If you want the flashlight to work only when the player actually has the "Flashlight" item, it's even simpler than that! Make an item in the Database (mine is called Torch, since I'm Australian ). Set it up to be a key item, and add the note [flashlight].

What this does is place the "flashlight" light on the player if they have this item in their inventory, and removes the light if they lose the item. To setup the "flashlight" settings, check the -ShoraLighting- plugin settings again, and look for a setting called [Lights: Custom]. In that setting there should be a light called flashlight that you can adjust the settings for. If the list of custom lights is empty, you can double-click empty space to make a new one (you will need to call it flashlight), or copy the ones from the -ShoraLighting- example project.