NPC Dialogue Shop

[Guardinthena]

@dragoonwys - That was the first thing I did, that's how I found out it was the NPC Dialogue Shop. (I honestly thought I had messed with the gold window in Yanfly's Core or something, but no) I turned off all of my plugins and went down the list turning them back on until the issue came up when the NPC Dialogue Shop plugin was switched on.

I don't think there is a plugin incompatibility going on though. My Gold Window dimensions in the NPC Dialogue Shop plugin are set at X: 20, Y: 488, and Width: 480. I have set my game window so that it is full screen, which is why the gold window is set like that.

I am NOT using Yanfly's Shop Core or the Multiple Currencies, but I am using BO Shops if that helps with anything. And of course, BO Shops is below NPC Dialogue.

The issue has been in my plugin for...well, at least a year now, I think. Whenever I first downloaded this plugin. At the time I didn't care because I had been intending to use Yanfly's multiple currencies and Yanfly's Variable Menu Window to display those multiple currencies, but my plans changed. So when I was trying to set up treasure chests yesterday is when I realized, oh yeah, I can't see my gold window in the menu for some reason. Why was that? Derp on me.

(Also, please forgive the shop keeper in the example pictures of the image, I haven't finished coloring her yet. It's a stand in sample piece)

Examples of issue

Spoiler

 

[ShadowDragon]

@Guardinthena while the shop gold shows the window, this seems to be correct?
while the Main Menu gold window is cut off, which dont see the value?

is the problem more the menu or the NPC Dialogue?

if NPC Dialog, see if she replies, in case it's the Main Menu (X button), does it
work if NPC Dialogue plugin is OFF? if it does work when the plugin is off, there
might be a smal compability issue, but also a easy fix.

 

[Guardinthena]

@ShadowDragon - Yes, the image of the shop Gold Window is correct, but when I go into the Main Menu the Gold Window retains the dimensions of the Shop window, even if I have never gone to the shop.

The problem is the NPC Dialogue shop. As I mentioned in an earlier post, the first thing I did was turn off all my plugins and go down the list. Eventually the issue replicated itself with the NPC Dialogue Shop plugin. When I turned it off, the Gold Window in the main menu is correct. When it is on, the window expands to the Shop dimensions.

 

[ShadowDragon]

I cannot replicated your, I change the width of the gold window, but it remain
correct in the main menu though, but aside from that though, when all my shops
are off, I got another weird issue

when Increase the gold window size, the gold is rather centerd than aligned "right",
even if it was aligned right, it is centered still, even if I make it 800 width, the
main menu gold window stays intact otherwise.

even the layout doesn't work on my side but what the problem can be on your end,
I have no clue, In case you update some plugins to a newer version, it might mess
it up, but whatever the exact cause it may be, something is bugging.

it might be possible that NPC Dialogue don't react to the params somehow
so I hope she can fix it. because I cant find anything related though D:

 

[Guardinthena]

I remember the centered alignment was a small bug in an older version of NPC Dialogue Shop that I brought up waaaay back and that was fixed. Which version do you have? Now I'm curious--wait, what version do *I* have??

Edit:
Okay, I seem to have the current version 1.01c, and the problem exists within that. Do you have an older version, @ShadowDragon?

 

[mjshi]

@Guardinthena
Hi, sorry! I haven't checked the forums in awhile (and for some reason stopped getting email notifications about my thread?). I uploaded a small fix, can you try it on the latest version 1.01d?

https://raw.githubusercontent.com/mjshi/RPGMakerRepo/master/NPCDialogueShop.js

 

[Guardinthena]

Ahhhhh! Mjshi! So excited to see that you responded to this so soon! I was afraid I would have to wait awhile. Totally get the email notification issue, it has happened to me too. I just installed and tested the new version and it works beautifully! Issue resolved! Thank you so much for everything that you've done for this wonderful plugin!

 

[shukiri]

Is there any way to show the item parameter/stat window shown in "buy" on the "sell" screen as well? Thanks.

 

[mjshi]

Is there any way to show the item parameter/stat window shown in "buy" on the "sell" screen as well? Thanks.

Not yet, but I can add that to the list of thing planned for this plugin.

 

[Zinnherz]

Hey, thank you for the great plugin! I've been using it for a while now and had a question concerning the status/parameter window.
Would it be possible for me to display the parameters as a 1*8 list instead of the default 2*4 one? That way, I would have a little more space for the merchant picture.

I've been looking through the js-file for the past hour or so, but can't seem to adjust the displayed rows/columns. Then again, I'm a noob with javascript, so I may have overlooked something.

Thanks!

 

[ShadowDragon]

@Zinnherz you can make the image bigger as replacing the windows and sizes anywhere
you like using the param "custom" and adjust the numbers in there.

if you want it easier to move windows, either print screen and place the location or use
SRD_Supertools plugin to move, adjust the windows etc easier within the playtest when
the scene is open for your look

 

[Zinnherz]

Thanks for the reply, but I didn't mean the window size. Sorry if my previous post was confusing.
I know I can change the window position and size easily through the plugin parameters. However, I'm wondering about the coloumns of the parameters window.

Let me show you what I mean using mjshi's example picture and some horrendous editing skills;



Oh, I also tried using SRD_Supertools again, but it doesn't give me the option for the columns.

 

[ShadowDragon]

@Zinnherz it should work, else it need modifying the plugin in order to get that.

I need to check what the window is called, if it's not default and from yanfly plugin that
is added, you can modify it in that plugin under a function.

searching for rows or columns can adjust those, but it's not inside the NPC dialogue plugin though.
so I guess you can do it from another plugin to make it like that.

but I dont know what plugin you use for that, one of YEP for sure, but I cant recall which one.

 

[mjshi]

@Zinnherz

You can modify how things are drawn in

Window_ShopStatus.prototype.drawEquipInfo

and specifically, parameters are drawn in

Window_ShopStatus.prototype.drawActorParamChange

There's no default way to change the columns, though.

 

[Zinnherz]

Hey, so after a while, I was finally able to figure it out. I was messing around with those numbers in the section you mentioned before, but didn't quite get the right one. However, I finally managed to get it the way I wanted and I'm really happy with how it turned out. (Screenshot attached for reference.)
Thank you so much again for the great plugin!

If anyone is interested; here is what I updated. (I'm a complete noob though, so if I butchered that code or made redundant changes, jokes on me.)

Spoiler: Changed Code

Window_ShopStatus.prototype.drawActorParamChange = function(x, y, actor, item1) {
var xo = x;
var width = this.contents.width - this.textPadding()*2;
this.contents.fontSize = this.standardFontSize() - fontDecrement;

for (var i = 0; i < 8; i++) {
this.resetTextColor();
this.changeTextColor(this.systemColor());
// Removed Dark Rectangels
this.drawText(TextManager.param(i), x, y);

var change = this._item.params - (item1 ? item1.params : 0);
this.changeTextColor(this.paramchangeTextColor(change));
this.drawText((change > 0 ? '+' : '') + change, x, y, width, 'right');
x += width + this.textPadding()*2;
if (i % 1 === 0) {
x = xo;
y += this.lineHeight();
}
}
};

 

[mjshi]

Hey, so after a while, I was finally able to figure it out. I was messing around with those numbers in the section you mentioned before, but didn't quite get the right one. However, I finally managed to get it the way I wanted and I'm really happy with how it turned out. (Screenshot attached for reference.)
Thank you so much again for the great plugin!

If anyone is interested; here is what I updated. (I'm a complete noob though, so if I butchered that code or made redundant changes, jokes on me.)

Spoiler: Changed Code

Window_ShopStatus.prototype.drawActorParamChange = function(x, y, actor, item1) {
var xo = x;
var width = this.contents.width - this.textPadding()*2;
this.contents.fontSize = this.standardFontSize() - fontDecrement;

for (var i = 0; i < 8; i++) {
this.resetTextColor();
this.changeTextColor(this.systemColor());
// Removed Dark Rectangels
this.drawText(TextManager.param(i), x, y);

var change = this._item.params - (item1 ? item1.params : 0);
this.changeTextColor(this.paramchangeTextColor(change));
this.drawText((change > 0 ? '+' : '') + change, x, y, width, 'right');
x += width + this.textPadding()*2;
if (i % 1 === 0) {
x = xo;
y += this.lineHeight();
}
}
};

Nice, I'm glad you were able to get it working!

Small suggestion, if (i % 1 === 0) is always true, so you can just remove the if statement to have it always run. Otherwise, doesn't look like there's redundant code to me

 

[ShadowDragon]

@Zinnherz really nice look of the scene, well done

 

[Rukee]

@mjshi Thank you for this much-needed plugin! It adds a lot to world-building!
I have a question if you don't mind, is it possible to add a text when the player buys or cancels. Something like 'Thank you!' or 'Didn't find anything you like?'
Such additions would be more immersive, if you have the time to consider them of course!
Thanks again for continuing to produce awesome plugins!

 

[dragoonwys]

@Rukee Are you thinking of when you exit the store menu? If so you can actually do that with some simple events, just set up the event to log the player's current gold into a variable and then later on check if the player's current gold is the same or not with a conditional branch.

 

[Rukee]

@dragoonwys That's a clever way of doing it!
But I was hoping we can utilize the help/dialogue window in the scene. currently, there's a dialogue for when you buy "how many do you want" I would like to add a "thank you" when the player actually buys something, and "come back later" when they cancel.