* @param Menu_ZoominKey
* @text Menu Zoomin-key
* @desc Key for zooming in. You can find more values in SE_keys.
* @parent Menu
* @type select
* @option none
* @option pageup
* @option pagedown
* @option +
* @option -
* @default pageup
*
* @param Menu_ZoomoutKey
* @text Menu Zoomout Key
* @desc Key for zooming out. You can find more values in SE_keys.
* @parent Menu
* @type select
* @option none
* @option pageup
* @option pagedown
* @option +
* @option -
* @default pagedown
*
* @param Menu_ResetZoomKey
* @text Menu Reset Zoom Key
* @desc Key for resetting the zoom. You can find more values in SE_keys.
* @parent Menu
* @type select
* @option none
* @option home
* @option end
* @option insert
* @option delete
* @default home
*
* @param Menu_ResetScrollKey
* @text Menu Reset Scroll Key
* @desc Key to reset the mapscroll. You can find more values in SE_keys.
* @parent Menu
* @type select
* @option none
* @option home
* @option end
* @option insert
* @option delete
* @default end SE.Minimap.Menu.ManualZoomKey_In = SE.Keys.fromStringParam(Params.Menu_ZoominKey); // <<< works
SE.Minimap.Menu.ManualZoomKey_Out = SE.Keys.fromStringParam(Params.Menu_ZoomoutKey); // <<< works
SE.Minimap.Menu.ManualZoomKey_Reset = SE.Keys.fromStringParam(Params.Menu_ResetZoomKey); // <<< works
SE.Minimap.Menu.ManualScrollKey_Reset = SE.Keys.fromStringParam(Params.Menu_ResetScrollKey); // <<< Error? Why? * @param Menu_ResetScrollKey
* @text Menu Reset Scroll Key
* @desc Key to reset the mapscroll. You can find more values in SE_keys.
* @parent Menu
* @type select
* @option none
* @option home
* @option end
* @option insert
* @option delete
* @default end
*
* @param PLACE_HOLDER_BECAUSE_STUPID_RMMV_BUG
* @text blablabla
* @desc Key to reset the mapscroll. You can find more values in SE_keys.
* @parent Menu
* @type select
* @option none
* @option home
* @option end
* @option insert
* @option delete
* @default endSE.Keys.fromStringParam(SE.Params.Minimap.Menu_ResetScrollKey) // works now
SE.Keys.fromStringParam(SE.Params.Minimap.PLACE_HOLDER_BECAUSE_STUPID_RMMV_BUG) // << bugsconsole.log(SE.Params.Minimap.Menu_ResetScrollKey);
console.log(SE.Params.Minimap.Menu_ResetScrollKey === "end");
console.log(SE.Params.Minimap.Menu_ResetScrollKey.length);
for (var i = 0; i < SE.Params.Minimap.Menu_ResetScrollKey.length; i++) {console.log(SE.Params.Minimap.Menu_ResetScrollKey.charCodeAt(i))}key_str = key_str.replace(/[\x00-\x1F\x7F-\x9F]/g, ""); // Remove hidden control characters... Because... RMMV bug... Again...
* @param IsVisibleByDefault
* @text Visible By Default?
* @desc Will the minimap be visible by default? This applies to each map. If set to false, it will also overrides any plugin commands upon entering a new map.
* @parent General
* @type boolean
* @default true
* // Get Plugin #Parameters
SE.Params = SE.Params || {};
SE.Params.Minimap = PluginManager.parameters('SE_Minimap');
// Fix stupid RMMV bug (https://forums.rpgmakerweb.com/index.php?threads/parameter-string-does-not-equal-string.113697/):
for (var key in SE.Params.Minimap) { SE.Params.Minimap[key] = SE.Params.Minimap[key].replace(/[\x00-\x1F\x7F-\x9F]/g, ""); }
function parseParameters (string) {
try {
return JSON.parse(string, (key, value) => {
try {
return parseParameters(value)
} catch (e) {
return value
}
})
} catch (e) {
return string
}
}SE.Params.Minimap = PluginManager.parameters('SE_Minimap')
// Stringify first, or incorporate the stringify in the parser function above first if you want.
const Params = parseParameters(JSON.stringify(SE.Params.Minimap))You're right that I accidentally compared a string with a bool in the console using === (my fault!).
SE.Minimap.VisibleByDefault = Params.IsVisibleByDefault.toLowerCase() === 'true'; * @param Menu_ResetScrollKey
* @text Menu Reset Scroll Key
* @desc Key to reset the mapscroll. You can find more values in SE_keys.
* @parent Menu
* @type select
* @option none
* @value none
* @option home
* @value home
* @option end
* @value end
* @option insert
* @value insert
* @option delete
* @value delete
* @default end
Your @Default parameters look normal to me
// Generated by RPG Maker.
// Do not edit this file directly.
var $plugins =
[
{"name":"Community_Basic","status":true,"description":"Plugin used to set basic parameters.","parameters":{"cacheLimit":"20","screenWidth":"1920","screenHeight":"1080","changeWindowWidthTo":"","changeWindowHeightTo":"","renderingMode":"auto","alwaysDash":"off"}},
{"name":"SE_Keys","status":true,"description":"v1.10 - This Key-Mapper is for plugin-developers and for other scripts that require this plugin.","parameters":{}},
{"name":"SE_Minimap","status":true,"description":"v1.20 - Minimap. Requires plugin \"SE_Keys\" (place this one below it).","parameters":{"General":"","MapStyle":"Scroll","GlobalMapZoom":"0.25","MinimapOpacity":"255","IsVisibleByDefault":"true","Positioning & Size":"","Window_X":"-2","Window_Y":"2","Width":"320","Height":"320","BorderWidth":"12","BorderHeight":"12","AlignmentHorizontal":"Right","AlignmentVertical":"Bottom","Player Blip":"","RenderPlayerBlip":"true","PlayerBlipGraphic":":player","PlayerIconWidth":"16","PlayerIconHeight":"16","PlayerBlinkDelay":"0","Vehicles":"","ShowVehicles":"true","ShowBoat":"true","ShowShip":"true","ShowAirship":"true","VehicleRenderWidth":"40","VehicleRenderHeight":"40","AlwaysShowVehicles":"false","Menu":"","MenuKey":"m","MenuPlayerDescription":"You","MenuZoom":"0.3. A value of 1 means 1:1","MenuLeft_WindowWidth":"240","MenuTopright_WindowHeight":"510","Menu_EventRenderSize":"24","Menu_PlayerIconSize":"64","Menu_MinManualZoom":"0.20","Menu_MaxManualZoom":"10.0","Menu_ZoominKey":"pageup","Menu_ZoomoutKey":"pagedown","Menu_ResetZoomKey":"home","Menu_ResetScrollKey":"end","Passability Map":"","PassabilityOverlayOpacity":"128","PassabilityColor":"#6B8E23","ImpassabilityColor":"#FF0000","Map Generator":"","MapGenTagColors":"#6B8E23 #00008B #8B4513 #006400 #F4A460 ####### ####### #FFFFFF","OverworldGenTagColors":"#6B8E23 #00008B #8B4513 #006400 #F4A460 ####### ####### #FFFFFF","MapGenRegionColors":"10:#6B8E23 11:#00008B 12:#8B4513 13:#006400 14:#F4A460","OverworldGenRegionColors":"10:#6B8E23 11:#00008B 12:#8B4513 13:#006400 14:#F4A460\r","Miscellaneous":"","AllowTeleportation":"true","StandardPadding":"0","WindowSkin":"Window_Minimap","FillColor":"0 0 0 255","MaintainAspectRatio":"true","FadeoutSpeed":"3","GlobalRequiredItem":"0","EventRenderSize":"16","AutoClearPOI":"false","RenderMinimapOverlay":"true","Fog of War":"","FoWEnabled":"false","DefaultFoWOverlay":"FoW","DefaultFoWRadius":"5","Manual Scrolling":"","AllowManualScrolling":"true","ManualScrollspeed":"24","ManualScrollKey_Up":"u","ManualScrollKey_Right":"k","ManualScrollKey_Down":"j","ManualScrollKey_Left":"h","Advanced & Debug":"","PlayerSpriteSourceframeWidth":"48","PlayerSpriteSourceframeHeight":"48","FrameSkip":"0","MapshotFilenameLength":"3","DebugMode":"true","RenderDebugGrid":"false","DebugGridImage":"DebugGrid01"}}
];
"true\n" === true
- false
"true\n" === "true"
- false
eval("true\n") === "true"
- false
eval("true\n") === true
- trueActually, RPG Maker is only supposed to use JSON-escaped-string for notes, lists and structs not for any other parameters, this was to ensure backwards compatibility with older versions of plugins for it.
* @param Menu_ResetScrollKey
* @text Menu Reset Scroll Key
* @desc Key to reset the mapscroll. You can find more values in SE_keys.
* @parent Menu
* @type select
* @option none
* @option home
* @option end
* @option insert
* @option delete
* @default end
Nothing to do with the use (or not) of the semi-colon in JS, it would have to do with the MV editor itself (which is written in a "proper" language C++ that uses semi-colons) that modifies the plugins.js file adding the carriage return when it should not.
Agree 100%. The input keymapper is awkward at best, basically it's only written to accommodate the keys which are used by default. Suggestion in the spoiler, but yeah I agree writing your own input key mapper in MV is not fun (and I've done it).
str = str.trim()1. I disagree that it's a "feature" to add a unexpected carriage return inside a string
100% agree, and carriage return inside a string is not valid JSON format. If that existed in a string, you would get a "Uncaught SyntaxError: Unexpected token in JSON at position __" when trying to use JSON.parse on that string. Of course, this doesn't happen because the configuration is stored in a .js file and not in a .json file, it kinda makes me think the devs didn't want to deal with asynchronous programming in order to load the plugin configuration.
I'm not sure exactly what you meant, but since you quoted me... Using eval for JSON-escaped-string for notes, lists and structs is can go either way for good for bad practice. What you should actually be doing is writing your own regex and parsing that; a popular example is Yanfly's Action Sequence. This way when codebase updates, only your adapters need to change, or not, depending on how polymorphic you made it. I think leaving it up to plugin writers is a good choice on the engine writer's behave. This is the reason why when the engine updates most plugins in RPGmakerMV becomes obsolete instantly.
I think you misinterpreted my sarcastic feature. This carriage return should actually be expected. From what I remember from my Compiler Class years ago, the reason why it is like that is that is because there is no other way to do it. You need a carry return, you need a delimiter, you need to know when something ends. It becomes exponentially times more difficult when using a high language like Javascript instead of a low one like C, how you do it is very much up to the designer. Take that as you will, my compiler in c wasn't very good.
Hence, why I mentioned the warning. What you stated here is more opinion than fact. Performance-wise, eval can even make the game more efficient because you don't have to write a parser for a single used call. You should definitely not use eval if you can't truly predict the input. You can actually see examples of this if you benchmark people's code. Not even considering eval is simply bad practice.
One of the deadly sins of programming is using eval in a loop. Eval should never be called more than once. As you stated above, the ideal way to use it should be used once, then cache its value. This is exactly what OP is doing.
I think this was a given. 'n' for newline and 'r' for return.
However, you can't see \r when calling it in a terminal, so I instinctively chose \n, which you can see because of where the cursor is. Seeing is believing.Carry return inside JSON is a very valid format. This is especially useful when using PHP server-sided to create a dynamic website using HTML or using Java to create editable objects or C++ to easily add mods.
let obj = {x:1,y:"hello\n"};
JSON.stringify(obj);
- "{"x":1,"y":"hello\n"}"The bug is as old as RMMV and I believe it was never looked into and Victor Sant (well-known scripter) also confirmed it. But they also never fixed some of our old annoyances dating back to other older RPG Makers.
