Requesting a compatibility patch for Yanfly's skill restriction script and ATB/Stamina Based Battle

deathsia

Pegisister
Veteran
Joined
Feb 26, 2014
Messages
651
Reaction score
55
First Language
English
Primarily Uses
Fomar0153's ATB/stamina script

Yanfly's Skill restrictions script

I'm no expert scripter but based on what I can tell, these two are overwriting the same methods and it's a wonder my game hasn't flung up a script error yet because they are both installed.

Basically as it stands, due to how both of these scripts are coded, skill cooldown counters won't update properly in battle.(As in if the skill has a cooldown of 5, it won't count down at all to zero, it just remains at 5 which leaves the skill unusable after its used once)

All I'm asking for is someone to create a patch that will allow yanfly's script to update its cooldown counters on skills. Nothing more, nothing less.
 

bgillisp

Global Moderators
Global Mod
Joined
Jul 2, 2014
Messages
13,819
Reaction score
14,624
First Language
English
Primarily Uses
RMVXA
I looked at the two scripts, and I think if you move Formar's script above Yanflys that should fix the problem. Yanfly has all aliased or new methods, and Formar has the oeverwitten methods. Try that and see what happens.
 

deathsia

Pegisister
Veteran
Joined
Feb 26, 2014
Messages
651
Reaction score
55
First Language
English
Primarily Uses
No dice, same result. :(
 

bgillisp

Global Moderators
Global Mod
Joined
Jul 2, 2014
Messages
13,819
Reaction score
14,624
First Language
English
Primarily Uses
RMVXA
Hmmm...ok, I had no luck finding the conflict. Formar only overwrites the update command at the start of the turn that I could see, chances are it is somehow related to that. However, I didn't see where Yanfly's skill restrictions called update....I'll poke at it, but my scripting knowledge (especially with battle systems) is mostly limited to seeing if they will play nice together and occasionally one line edits to make it behave better in my game.

Do you have any other scripts at all? Anything that calls that update method Formar called might cause the issue (Yanfly Battle engine by chance?).
 

deathsia

Pegisister
Veteran
Joined
Feb 26, 2014
Messages
651
Reaction score
55
First Language
English
Primarily Uses
Yep, I use yanfly battle engine. is that a cause?
 

bgillisp

Global Moderators
Global Mod
Joined
Jul 2, 2014
Messages
13,819
Reaction score
14,624
First Language
English
Primarily Uses
RMVXA
Yep. Both Yanlfy and Formar overwrote on_turn_end it appears, and Formar's script is getting priority, so the cooldowns are not processing.

Try this and see if it works. I can't actually test it at the moment, but it does compile correctly at least. All I did was merge the two update commands from the battle engines into one function (using Formar's version as a base, as I assume you have Yanfly battle engine then Formar's script?), and copy/pasted the update cooldown line. Put it last in your scripts.

http://pastebin.com/vKH76bLj

If you had it Formar then Yanfly's battle engine, it will be a quick edit to make it match your old behavior, just let me know.
 

deathsia

Pegisister
Veteran
Joined
Feb 26, 2014
Messages
651
Reaction score
55
First Language
English
Primarily Uses
Nope, not working. >.<

Edit: Would yanfly's battle symphony have any effect on this?
 
Last edited by a moderator:

bgillisp

Global Moderators
Global Mod
Joined
Jul 2, 2014
Messages
13,819
Reaction score
14,624
First Language
English
Primarily Uses
RMVXA
Probably. I don't use battle symphony myself, so no idea. But anything that has any effect on the battle system is probably going to affect this, so you are going to need a patch to make *all* of them play nice.
 

deathsia

Pegisister
Veteran
Joined
Feb 26, 2014
Messages
651
Reaction score
55
First Language
English
Primarily Uses
Well, I found out that by pasting

$game_party.update_restrictions$game_troop.update_restrictionsinto your patch caused it to refresh the skill but the problem is that it makes it as if the cooldowns were never applied so that didn't work. :/
 

bgillisp

Global Moderators
Global Mod
Joined
Jul 2, 2014
Messages
13,819
Reaction score
14,624
First Language
English
Primarily Uses
RMVXA
Hmmm....Afraid I'm stumped at this point on how to get all of them to play nice. Anyone else out there got an idea?
 

deathsia

Pegisister
Veteran
Joined
Feb 26, 2014
Messages
651
Reaction score
55
First Language
English
Primarily Uses
AH-HA! I did a bit of searching a found an easy fix on an OLD PAGE the script existed on a third party site

Turns out adding:

@subject.update_cooldowns

Right after a given line fixed it!
 
Last edited by a moderator:

Latest Threads

Latest Posts

Latest Profile Posts

Our Lore Wizard, Buttercup, just emailed me a draft of one of our in-game lore books, and it's one of my favorites so far. Her books are really bringing a vibrant history to Evergloom!

I've posted it under a spoiler tag called 'A study in 43rd Century Poetry' in our development thread!
Whoops, the corner of my map is as big as GALV's whole demo map xD
wops.PNG
A little more of the CMS. #rm2k #DestinyPatch
QUhhNBK.gif
StarkSnow wrote on DisguisedCrows's profile.
Hello.
Gotta love when RM just decides it's done with existence and closes when you're in an event.

Forum statistics

Threads
112,324
Messages
1,067,344
Members
145,951
Latest member
shirako
Top