Skill Extender add-on/tweak

Discussion in 'JS Plugin Requests' started by SwiftSign, May 31, 2017.

  1. SwiftSign

    SwiftSign Veteran Veteran

    Messages:
    184
    Likes Received:
    45
    First Language:
    English
    Primarily Uses:
    RMMV
    I've started using sumrndmdde's skill extender system, but I've found the display of the skills somewhat annoying - the window stretches depending on the skills (endlessly, if you have too many).

    I was wondering if someone with the know-how could make an addon to make the height (and perhaps number of columns too) of the box that opens for an extended skill customisable.

    Skill Extender link: http://sumrndm.site/skill-extender/
     
    #1
  2. kovak

    kovak Silverguard Veteran

    Messages:
    1,243
    Likes Received:
    1,546
    Location:
    I'm from the Hu3
    First Language:
    PT - EN
    Primarily Uses:
    RMMV
    #2
  3. SwiftSign

    SwiftSign Veteran Veteran

    Messages:
    184
    Likes Received:
    45
    First Language:
    English
    Primarily Uses:
    RMMV
    Unfortunately it seems incompatible when changing the height. Any change reverts back on the following turn.
     
    Last edited: May 31, 2017
    #3
  4. kovak

    kovak Silverguard Veteran

    Messages:
    1,243
    Likes Received:
    1,546
    Location:
    I'm from the Hu3
    First Language:
    PT - EN
    Primarily Uses:
    RMMV
    Have you reloaded the game after closing the super tools engine?
     
    #4
  5. SwiftSign

    SwiftSign Veteran Veteran

    Messages:
    184
    Likes Received:
    45
    First Language:
    English
    Primarily Uses:
    RMMV
    Yep, tried lots of different things (including in a new game) and height always reset.


    Edit// this seems to be the bit specifying the height. However if I write ____px it doesn't work :( Javascripppttt

    Window_SkillExtend.prototype.updatePlacement = function() {
    this.makeItemList();
    this.height = this.fittingHeight(this._data.length);
    this.x = (Graphics.boxWidth - this.width) / 2;
    this.y = (Graphics.boxHeight - this.height) / 2;

    After a couple dozens failures I just realised I could add a fraction and some basic javascript to make it:
    this.height = this.fittingHeight(Math.round((this._data.length)/2));

    Although if anyone knows a cleaner way please feel free <3
     
    Last edited: Jun 1, 2017
    #5
  6. SumRndmDde

    SumRndmDde Follower of RNGesus Veteran

    Messages:
    224
    Likes Received:
    409
    Location:
    an alternate dimension.
    First Language:
    English
    Primarily Uses:
    RMMV
    @SwiftSign
    Oooof, looking back on it, letting the window grow without a limit is not the smartest idea. :rswt
    I have updated the plugin with a parameter that allows you set a "maximum" amount of visible rows for the window.

    Alternatively, if you wish to continue modifying the code yourself, simply input the columns you wish into the function to make it work:

    this.height = this.fittingHeight(2);

    will set the window to have 2 columns.
    So using Math.max, you can do:

    this.height = this.fittingHeight(Math.max(this._data.length, 10));

    to make it so there will be columns to fit the amount of choices, but remain at 10 if there are more than 10 choices.
     
    #6
    SwiftSign likes this.

Share This Page