Sounds like a decent idea, it doesn't remind me too specifically of any one thing. The ability you gave as an example, though, +5% gold, that sounds more like a 'perk', if you will. Any plans to split up 'skills' and 'perks', or any sort of categorization in mind? Perks always remind me of things that you either 'have to pick one of' or otherwise 'aren't always essential to completing the game.
Skills/Abilities both remind me of techniques or moves the player can use inside or outside of battle. I imagine those are more like the ones you'd need to progress the main story?
It depends how it's handled, +5% gold can also be considered a passive skill and thus a Skill, or I would say a Skill/Ability, but, as well as that, it could be handled with being equipment based, and then added as a Skill/Ability when Equipped, rather than a skillset immediate based.
From the sound of it it'll be added into one of the party member skillsets, in which case
@PhxFire if this is the case, then I'd recommend having at least a passive skills category skill types as well as main skill category skill types.
Unless the +5% Gold is a Skill you use in battle itself to gain that passive effect.
You can, of course, call any of your skill types what you want.
Just another thought to keep in mind, if you do have only a single skill type and many many skills then it won't be as easy to scroll through all those skills and it may feel a bit messy or complex or both to the player, of course though if you plan to limited with what skills you bring in battle that may not be a problem then. Otherwise, as said above, you can separate them into differer skill types or if it's equipment based, limit the amount of slots the player has to equip something.
It all depends how many skills there are, but it sounds like a game that will eventually give many many skills.
But, what you said here all sounds fine!