TSR

The Northern Frog
Veteran
Joined
Nov 14, 2019
Messages
478
Reaction score
568
First Language
French
Primarily Uses
RMMZ
Thank you so much for this plug-in!
Hello, and thank you for your comment :rock-right:

I am noticing one minor issue, though. The State Resist isn't working for me at all.
I started a fresh project and got the same results.
Here's my scenario: Enemy has skill that inflicts poison. Actor has armor equipped
that resists the poison state. When I was on version 1.1.4 it would actually ignore the state
resistance and poison the actor anyway. After installing the 1.2.5 update everything is working
on the technical end, but it still will not give me the "no effect" popup.
Well, since I'm not currently working actively on my MV project with this plugin, I thought that maybe I've overlooked something or some later update somehow broke this feature. So I went and ran a few test in a test project. Unfortunately, it seems I'm not able to reproduce what you reported.

I tested in a project with only TSR_Popups AND in a project with only YEP_BattleEngineCore along with TSR_Popups.

I tested with both the Attack State trait and a skill that have the Add State effect.

I tested with the State Resist trait and the State Rate 0% trait, as actors, enemies, classes and armors traits.

The 'No effect' popups does appears everytimes...

Can't tell what's happening on your side, though... But note that my plugin has nothing to do with applying the state or not. It just check if the target has a state resist trait or state rate 0%, and show the popup accordingly. So when you say 'When I was on version 1.1.4 it would actually ignore the state resistance and poison the actor anyway.' The fact that poison was applied anyway wasn't related to my plugin, but something else, in the database or other plugins.

I would like to help more, but I need to be able to reproduce the bug so I can track it.
 

TheWillardofOz

Villager
Member
Joined
Nov 26, 2019
Messages
14
Reaction score
5
First Language
English
Primarily Uses
RMMV
I tested in a project with only TSR_Popups AND in a project with only YEP_BattleEngineCore along with TSR_Popups.

I tested with both the Attack State trait and a skill that have the Add State effect.

I tested with the State Resist trait and the State Rate 0% trait, as actors, enemies, classes and armors traits.

The 'No effect' popups does appears everytimes...
I think I figured it out! The skills my enemies are using do not do any damage. Damage is set to 'none' and they simply add the state. Once I turned hp damage on and added something to the damage formula the 'no effect' started popping up.

Is there a way to get the state resist popups without needing to include damage to the attack? A valid workaround would be to just put zero in the damage formula, but I'd prefer to not have any number show up at all.
 
  • Like
Reactions: TSR

TSR

The Northern Frog
Veteran
Joined
Nov 14, 2019
Messages
478
Reaction score
568
First Language
French
Primarily Uses
RMMZ
Hello again!
Is there a way to get the state resist popups without needing to include damage to the attack?
Good call! I'll fix that and post a new version. Allow me some time, though.

Thanks for reporting that; stay tune!
Regards :rock-right:
 
Joined
Aug 10, 2021
Messages
3
Reaction score
2
First Language
English
Primarily Uses
RMMV
Good day @TSR !
I was searching far and wide for this plug in and it is a GOD SENT. I am so glad to have found this.

However there is a small issue I'm having with this plug-in where the sprites for the Damage Numbers and the Weak Icons are slightly offset? I'm having a very hard time wording this, so I will show you this picture instead.
1628534061041.png
I am not sure what the problem is here... I am incredibly confused?
If the issue is a need to re-scale and or resize the sprites then I'll try and do so, but If that isn't the case.

Thanks in advance! This is a great plugin so far!
 

TSR

The Northern Frog
Veteran
Joined
Nov 14, 2019
Messages
478
Reaction score
568
First Language
French
Primarily Uses
RMMZ
Hello @Stargazer_Nisshoku and thanks for your comments!

I can't tell how it can do this. If I'm not wrong, you're using the damage sprite sheet (not strings), and it seems the framing of the digits is all messed up. Did you change something in the sheet? Other plugins might interfere too, so you may want to try it in a new project with only my plugin and using the same sheet.​
 

ShadowDragon

Realist
Veteran
Joined
Oct 8, 2018
Messages
6,321
Reaction score
2,467
First Language
Dutch
Primarily Uses
RMMV
@Stargazer_Nisshoku if you changed the sheet to a different font which
is possible, bu keep in mind, that EACH digit has the same size, like 40x40,
and not different on each digit like 40x40, 40x30, 40x50 etc, they must
have the same size for each digit.

as for the weak/critical, I dont know how this one is calculated, but that is something
you need to test, probably as will at least 40 height as the difit height, and it should
work after that, if not, you could show the plugin database to see if something is
interfering with the TSR_Popups in order to fix this.

as for your digits, it's different from the sheet as provided made by TSR,
and changing it is fine though, but you need to follow the rules :)
 
Joined
Aug 10, 2021
Messages
3
Reaction score
2
First Language
English
Primarily Uses
RMMV
Hello @Stargazer_Nisshoku and thanks for your comments!

I can't tell how it can do this. If I'm not wrong, you're using the damage sprite sheet (not strings), and it seems the framing of the digits is all messed up. Did you change something in the sheet? Other plugins might interfere too, so you may want to try it in a new project with only my plugin and using the same sheet.​
I went in and rechecked and I made the mistake of renaming the TSR Popup file from TSR_Damage to just Damage and after fixing the names of all the files it works well now lol.

After going back i feel really dumb for not leaving it as is.
But thanks for your time I appreciate the help.
 

SifDoge

Veteran
Veteran
Joined
Jun 30, 2014
Messages
37
Reaction score
14
First Language
English
Primarily Uses
RMMV
I found a bug, when 'weak' and 'critical' hit occur at the same time, it only show critical pop up
 

stramin

Veteran
Veteran
Joined
Nov 4, 2012
Messages
342
Reaction score
171
First Language
spanish
Primarily Uses
N/A
I found a bug, when 'weak' and 'critical' hit occur at the same time, it only show critical pop up
Is not a bug, on the documentation, inside the plugins it explains the popups priority.

1650753170737.png

I love this plugin! ♥

-------------- EDITED ----------

I am having a problem using this plugin, I have this Yanfly tag to evaluate if the target is weak against an element:

Code:
<Post-Damage Eval>
if(target.elementRate(9)>1){
  target.startAnimation(197);
}
</Post-Damage Eval>

It works fine, but if I enable the TSR popup plugin it stops working, do you know why?

(I installed TSR pluggins below Yanfly plugins)
 
Last edited:
  • Like
Reactions: TSR

ShadowDragon

Realist
Veteran
Joined
Oct 8, 2018
Messages
6,321
Reaction score
2,467
First Language
Dutch
Primarily Uses
RMMV
@stramin are your YEP plugins are in the correct order?
check the YEP website or in my spoiler for ALOE_Guvner plugin
which I updated to see which one is out of place.
 

TSR

The Northern Frog
Veteran
Joined
Nov 14, 2019
Messages
478
Reaction score
568
First Language
French
Primarily Uses
RMMZ
Hello @stramin
At the very bottom of the plugin documentation (in the version and compatibility section), you'll find instructions about plugins order:

"The plugin must be placed just bellow YEP_BattleEngineCore, but above all other Yanfly battle-related plugin."

Regards
 

stramin

Veteran
Veteran
Joined
Nov 4, 2012
Messages
342
Reaction score
171
First Language
spanish
Primarily Uses
N/A
@stramin are your YEP plugins are in the correct order?
check the YEP website or in my spoiler for ALOE_Guvner plugin
which I updated to see which one is out of place.
Yes, they are in order, thank you.

1650823679585.png

What an useful plugin!

Hello @stramin
At the very bottom of the plugin documentation (in the version and compatibility section), you'll find instructions about plugins order:

"The plugin must be placed just bellow YEP_BattleEngineCore, but above all other Yanfly battle-related plugin."

Regards

Oh I see, Thank you!

Now I wonder if it should be below or above @caethyril YEP_Battle_Engine_Fix :kaoback:
1650822951885.png
 

ShadowDragon

Realist
Veteran
Joined
Oct 8, 2018
Messages
6,321
Reaction score
2,467
First Language
Dutch
Primarily Uses
RMMV
@stramin if the fix is for the battleCore, than that one below it,
than popups.

the YEP plugin I updated has around 92 plugins to 203+ plugins.
it has 2 more which is has not, so it is faster to check the website :)
I'm not sure about the TSR_textColorAddon plugin though, as I have
it just below the YEP_EngineCore mysave without issues.

if the problem persist, or give an error, show the log of that one,
and TSR can fix it if that is the case or needed.
 

sawworm

Sir Waste Time A Lot
Veteran
Joined
Jul 28, 2013
Messages
141
Reaction score
43
First Language
Turkish
Primarily Uses
RMVXA
Hello TSR, is there a way to change the popup X and Y locations? They popup too close to my actors
And for the image, I can't seem to make the popups smaller when I use a custom png~ Also for the string, the fonts are too small, like miss/evade how can I make them bigger without changing the popup damage numbers
 

TSR

The Northern Frog
Veteran
Joined
Nov 14, 2019
Messages
478
Reaction score
568
First Language
French
Primarily Uses
RMMZ
Hello @sawworm
Hello TSR, is there a way to change the popup X and Y locations? They popup too close to my actors
And for the image, I can't seem to make the popups smaller when I use a custom png~ Also for the string, the fonts are too small, like miss/evade how can I make them bigger without changing the popup damage numbers
There's a parameter to set the popups Y anchor point, and the string popups font size can also be changed in the parameters.

Regards.
 

TheWillardofOz

Villager
Member
Joined
Nov 26, 2019
Messages
14
Reaction score
5
First Language
English
Primarily Uses
RMMV
Hi again!

I seem to be having a compatibility issue with YEP_BattleSysSTB. When enemies attack the player with a state that they are immune to the popup will say RESIST as it should, but then just before the turn ends I get a barrage of two, three, or sometimes four more RESIST popups.

I've done a lot of trial and error with rearranging plugins and turning them on/off. For whatever reason these two just don't like each other very much in that very specific area. Any chance this is something that can be looked at? Thanks!
 

Attachments

  • Screenshot 01.png
    Screenshot 01.png
    464 KB · Views: 3
  • Screenshot 02.png
    Screenshot 02.png
    469.4 KB · Views: 4
Last edited:

TSR

The Northern Frog
Veteran
Joined
Nov 14, 2019
Messages
478
Reaction score
568
First Language
French
Primarily Uses
RMMZ
Hello, it is probably due to the regeneration phase which occurs at the end of all battlers turn on STB system. I'm not using MV anymore so I can't go and dig into that, beside changing it would probably break some other features...
But looking at the code I can try to guide you how to edit your own version.
From what I think, you could comment out line 1859 to disable the elemental check during the regeneration phase, which should solve your issue (haven't tested it, though):
Code:
Game_Battler.prototype.regenerateHp = function() {
    if (Imported.YEP_X_TickBasedRegen) {
      var value = Math.floor(this.mhp * this.hrg);
      value = Math.max(value, -this.maxSlipDamage());
      if (value) {
        this.gainHp(value);
      }
      this.result()._haveElementEffect = false
    } else {
      let preValue = Math.floor(this.mhp * this.hrg);
      preValue = Math.max(preValue, -this.maxSlipDamage());
      let value = Math.floor(this.mhp * this.getTickElementRate());
      value = Math.max(value, -this.maxSlipDamage());
      if (!Imported.YEP_X_ExtDoT) {
        //this.checkElementalPopup(preValue, value);   <<< THIS PART HERE
      }
      if (value) {
        this.gainHp(value);
      }
    }
    this.result()._StateResistRequest = false
  };

Tell me if it work, but I'm not sure I can help further if it doesn't...
Regards :rock-right:
 

TheWillardofOz

Villager
Member
Joined
Nov 26, 2019
Messages
14
Reaction score
5
First Language
English
Primarily Uses
RMMV
Thanks for the reply!

And forgive my ignorance (I'm still struggling with Java and coding in general), but what do you mean by comment it out?
 

Latest Threads

Latest Posts

Latest Profile Posts

New sprites & animations for Mint and Beri are coming along!
Guh-Colorbound.gif
ScreenShot_10_5_2022_4_44_8.png
Mad O' Malley... a stick figure that's afraid of it's existence being erased. so they always start battle in an anxious state.
Before, I was drawing all the sprite work, super big and shrinking it down. Which was really time consuming if thing's changed. So instead I'm drawing the characters sketch, and then remaking it with pixel art instead.
Why are job interviews so terrifying. :kaodes:

Forum statistics

Threads
125,801
Messages
1,173,662
Members
164,964
Latest member
oliveleaf
Top