Urgent help with Modern Algebra's Quest Journal needed

Discussion in 'RGSSx Script Support' started by Kes, May 28, 2015.

Thread Status:
Not open for further replies.
  1. Kes

    Kes Global Moderators Global Mod

    Messages:
    20,611
    Likes Received:
    10,514
    First Language:
    English
    Primarily Uses:
    RMVXA
    This is the second project that I have used  Modern Algebra's Quest Journal (found here) and up until now it's been without a problem.  Now I've hit a major problem.  I have tried to get a response from Modern Algebra over on rmrk.net, but he is not responding.  The problem is most easily explained by a screen shot.

    [​IMG]

    As you can see, the last objective is being obscured by the line which separates objectives from the rewards section.  It's as if I have run out of space and I still have 3 more objectives to go before quest complete.  I cannot scroll down any further to see the rewards, 

    Can anyone suggest a way of curing this?  Is it just that there's some length for this part coded in which can be increased?

    I have a second problem which it would be very nice to cure, if at all possible.

    Up until now I have had 2 totally separate parties, using Tsukihime's Party Manager script (found here ).  They have had their own inventories and gold, and - without me having to do anything - their own separate list of quests.  This was fine, because all side quests could only be discovered and completed by a specific party, they were not shared in any way.

    I have just merged the two parties, and their inventories and gold have combined without a hitch.  However, the quests of the second party (which has been merged into the first party), did not add themselves to the quest list.  In one sense this is not the end of the world, because if they haven't completed them I can put blocks on so that they can't go back and finish them as a joint team.  However, it would be nice if they did show up.  Is this possible?
     

    btw, I have no idea what that line of question marks is all about.  They just showed up.

    Thank you.
     
    #1
  2. cabfe

    cabfe Cool Cat Veteran

    Messages:
    2,301
    Likes Received:
    2,369
    Location:
    France
    First Language:
    French
    Primarily Uses:
    RMVXA
    About your quest journal bug, does swapping to another quest and then go back to this one change anything?

    I've had a similar problem, maybe it's related.
     
    #2
  3. Kes

    Kes Global Moderators Global Mod

    Messages:
    20,611
    Likes Received:
    10,514
    First Language:
    English
    Primarily Uses:
    RMVXA
    No it doesn't change anything.  Nor does it make a difference whether I view it in the All Quests list (as shown in the screen shot) or in the Uncompleted Quests list.

    EDIT

    This is the only quest I have which is so long.  The others, being side quests, typically have only 3 or so objectives.
     
    Last edited by a moderator: May 28, 2015
    #3
  4. Trihan

    Trihan Speedy Scripter Veteran

    Messages:
    1,483
    Likes Received:
    977
    Location:
    Buckie, Scotland
    First Language:
    English
    If this quest present in the project you sent me to fix before? If not, can you send it to me again and I'll take a look?
     
    #4
  5. Kes

    Kes Global Moderators Global Mod

    Messages:
    20,611
    Likes Received:
    10,514
    First Language:
    English
    Primarily Uses:
    RMVXA
    Yes it is in that project.  That's a very kind offer on your part.
     
    #5
  6. Trihan

    Trihan Speedy Scripter Veteran

    Messages:
    1,483
    Likes Received:
    977
    Location:
    Buckie, Scotland
    First Language:
    English
    How do I get to that quest to check it?
     
    #6
  7. cabfe

    cabfe Cool Cat Veteran

    Messages:
    2,301
    Likes Received:
    2,369
    Location:
    France
    First Language:
    French
    Primarily Uses:
    RMVXA
    It looks like the @draw_y variable is not set to a correct value in this case. Probably something to do in the def data_height section.

    Unfortunately, I tweaked this script too much for multilanguage support and I deactivated the Rewards parts so I won't be able to test here.

    For testing, you can try adding objectives one by one to see when it starts to happen.

    And then, try adding other (dummy?) objectives. Since some of them hold on 1 line and others do not, maybe the script has a bug in calculating the total height.

    With these tests, you should be able to tell if it's related to the number of objectives or their lines' content.

    Not enough to fix, but that'd give a good clue.
     
    #7
  8. Kes

    Kes Global Moderators Global Mod

    Messages:
    20,611
    Likes Received:
    10,514
    First Language:
    English
    Primarily Uses:
    RMVXA
    do you mean you need a save file?
     
    #8
  9. Trihan

    Trihan Speedy Scripter Veteran

    Messages:
    1,483
    Likes Received:
    977
    Location:
    Buckie, Scotland
    First Language:
    English
    Or instructions on what I need to do to have that quest in the log. Either or.
     
    #9
  10. Kes

    Kes Global Moderators Global Mod

    Messages:
    20,611
    Likes Received:
    10,514
    First Language:
    English
    Primarily Uses:
    RMVXA
    I think the only way is with a save file.  I'll pm you the dropbox link in just a minute when I've put it there.
     
    #10
  11. Trihan

    Trihan Speedy Scripter Veteran

    Messages:
    1,483
    Likes Received:
    977
    Location:
    Buckie, Scotland
    First Language:
    English
    Got it. The script's code for drawing the horizontal line is pretty much always assuming you'll be displaying rewards at the end and not text. Replace the draw_line method with this and it should work:

    def draw_line

        if @quest.rewards.size == 0 && @draw_y > 0

          draw_horizontal_line(@draw_y + line_height, 2)

        else

          draw_horizontal_line(@draw_y + (line_height / 2) - 1, 2)

        end

      end
     
    Last edited by a moderator: May 28, 2015
    #11
    Kes likes this.
  12. Kes

    Kes Global Moderators Global Mod

    Messages:
    20,611
    Likes Received:
    10,514
    First Language:
    English
    Primarily Uses:
    RMVXA
    It works splendidly!!  thank you.

    While you're in awesome mode, you wouldn't have any thoughts about my second problem would you?  I could send you the save file for after the parties have merged so you can see what it's like.
     
    #12
  13. Trihan

    Trihan Speedy Scripter Veteran

    Messages:
    1,483
    Likes Received:
    977
    Location:
    Buckie, Scotland
    First Language:
    English
    Sure.
     
    #13
  14. Kes

    Kes Global Moderators Global Mod

    Messages:
    20,611
    Likes Received:
    10,514
    First Language:
    English
    Primarily Uses:
    RMVXA
    Thanks.  I've pm'd you with another save file.
     
    #14
  15. Iavra

    Iavra Veteran Veteran

    Messages:
    1,797
    Likes Received:
    856
    First Language:
    German
    You would need to extend Game_Party.merge. Each party has its own journal variable in @quests. An easy solution would be something like this (untested):

    class Game_Party    alias :quest_merge :merge    def merge(party2)      quest_merge(party2)      merge_quests(party2)   end    def merge_quests(party2)      party2.quests.list.each{|quest| @quests[quest.id] = quest}   end end
    Note, that this will simply add all quests of party 2 to the journal of party 1, overriding any previous progress. An additional algorithm would be needed to merge the quest objects.

    Sadly, i currently don't really have the time to figure that out as well.
     
    #15
    Kes likes this.
  16. cabfe

    cabfe Cool Cat Veteran

    Messages:
    2,301
    Likes Received:
    2,369
    Location:
    France
    First Language:
    French
    Primarily Uses:
    RMVXA
    Good to know that it got fixed, although I don't understand why it didn't happen before.

    Or maybe it's the only quest with a different reward section? You didn't mention that part, though.

    I hope there won't be any side effects.
     
    #16
  17. Kes

    Kes Global Moderators Global Mod

    Messages:
    20,611
    Likes Received:
    10,514
    First Language:
    English
    Primarily Uses:
    RMVXA
    @Iavra

    Thanks for that.

    @cabfe

    I didn't mention it because, to be honest, I'd forgotten.  Yeah, pathetic, I know.
     
    #17
  18. Trihan

    Trihan Speedy Scripter Veteran

    Messages:
    1,483
    Likes Received:
    977
    Location:
    Buckie, Scotland
    First Language:
    English
    I don't think anyone's thought to use it for a "main quest" with no rewards in it yet. :p
     
    #18
  19. Kes

    Kes Global Moderators Global Mod

    Messages:
    20,611
    Likes Received:
    10,514
    First Language:
    English
    Primarily Uses:
    RMVXA
    That's because there is no 'reward' in the traditional sense - and also because when the main quest is finally completed, the game ends, so you'd never get a reward anyway.
     
    #19
  20. cabfe

    cabfe Cool Cat Veteran

    Messages:
    2,301
    Likes Received:
    2,369
    Location:
    France
    First Language:
    French
    Primarily Uses:
    RMVXA
    Some games split the main quest into several "steps" with a reward for each, but of course the ultimate reward is beating the game and getting a satisfying end. B)
     
    #20
Thread Status:
Not open for further replies.

Share This Page