Vlue combo script stops MP cost

[Kes]

I am using Vlue's Basic Combo script. However, now I have begun battle testing, a problem has shown up.

An actor has a healing skill which can be used outside of battle. When it is used outside battle, the heal takes effect, but the MP is not removed, meaning that the player has a totally free heal. In battle is fine, the MP is subtracted in the normal way.

Can anyone see how that is happening, and what might be done to fix it?
Thanks.

 

[GGZiron]

You can try with this two bulelts.
The first one you put before Vlue's script.

class Game_Battler
  alias_method :use_item_original, :use_item
end

And this one, after his script:

class Scene_ItemBase < Scene_MenuBase
    def use_item
    play_se_for_item
    user.use_item_original(item)
    use_item_to_actors
    check_common_event
    check_gameover
    @actor_window.refresh
  end
end

In my test seems to solved the problem, although didn't tested too deeply. What I do is to make actor use the original
use_item method, when from Scene Item Base, one which will take the skill cost (MP reduction).
Vlue modified use_item at game battler to not take cost. I could add the cost right at his modifed method, but then during battle the skill would cost double. Seems he take the skill cost somewhere else, but that works only in battle scene.

Edit: Actually, you can put both bullets before Vlue's script.

 

[Kes]

@GGZiron Just tested this and seems to work perfectly.
Thank you very much for this. I would have been very sad to have to ditch the combo script as I've built my skill system around it for this project. Now I shan't have to.

 

[GGZiron]

You are welcome . Though I am not too happy with this solution I gave above, so I have one more.
Again I give two bullets.
The first one must be above combos script(if in same page, above everything else).

Spoiler: First Bullet

class Game_Battler
  alias_method :use_item_original, :use_item
end

And the second one is after (this time for real, must be after). If on same page, then after everything, including the last end operator.

Spoiler: Second Bullet

class Game_Battler
 
  alias_method :combos_use_item, :use_item
 
  def use_item(item)
    return unless item
    if SceneManager.scene.is_a?(Scene_Battle)
      combos_use_item(item)
    else
      use_item_original(item)
    end
  end
 
end

I think this way is bit better, and have better compability. Tested it and worked, but of course, I recomend you to test it too, if you go with this.

 

[Kes]

@GGZiron I have tested this out and it appears to be working as intended.
Thank you for continuing to refine your solution. Much appreciated.