CarbonatedBlood

Villager
Member
Joined
Sep 15, 2021
Messages
8
Reaction score
1
First Language
English
Primarily Uses
RMVXA
I am having an issue regarding the use of both Yanfly's Class System and Yanfly's Learn Skill scripts. When I access "Skills" from the menu, then "Learn Skills", I am shown not only the skill type of the current class, but all other classes that I can change to with use of the Class System Script. The issue does not occur when the Class System script is absent, instead only displaying the skill type of the current class.

Ideally, I want to allow classes to have unique combinations of skill types (Fighter: Sword, axe, bow. Hunter: Bow, lance, dagger. Mage: Wand, dagger, whip). The only issue I suffer is seeing every skill type when learning skills, if there is not a means to achieve this while using both scripts, then I'll just part with the Class System, which I'd like not to as it's a very pleasing script.

Attached is a demo to example the problem.
 

Attachments

  • test.rar
    1.3 MB · Views: 2

Tiamat-86

old jrpg gamer
Veteran
Joined
Dec 5, 2017
Messages
998
Reaction score
461
First Language
english
Primarily Uses
RMMV
i dont have a solution but i can point out that this probably wont be the only issue you'll come across with class change + skill learn system.
you'll also find that say hunter learns a bow skill at a low level that fighter doesnt learn until a much higher level or doesnt normally even learn that skill at all, the fighter can end up being able to use that skill at lv1 after you learn it with hunter just because it is a matching skill type.
i originally encountered that issue with learning high level black mage skills then switch to low level red mage that would only learn up to middle tier white and black magic.

my solution ended up being to completely change the class/learning system into a single "build your own class" with equipping skill and learning from skill trees.
some people just made different skill type for each class and having duplicate of skills (like white magic type: cure, and red magic type: cure), that system just looked weird to me with skill learn plugin (literally had to learn "Cure" twice) but was fine when it was only level X learning.

every thread ive seen of issues involving class change + skill learn i dont think ever got solved because they would all involve changing the .js files in different ways unique to each different class and skill type approach. and there's been at least a dozen different approaches.
these 2 plugins when combined definitely the combo with the most issues.

you wouldnt be the 1st to just opt out of the class change plugin and just use evented class change system. or the vise versa of opting out of the skill learn plugin and use other methods to buy skills.
 
Last edited:

CarbonatedBlood

Villager
Member
Joined
Sep 15, 2021
Messages
8
Reaction score
1
First Language
English
Primarily Uses
RMVXA
i dont have a solution but i can point out that this probably wont be the only issue you'll come across with class change + skill learn system.
you'll also find that say hunter learns a bow skill at a low level that fighter doesnt learn until a much higher level or doesnt normally even learn that skill at all, the fighter can end up being able to use that skill at lv1 after you learn it with hunter just because it is a matching skill type.
i originally encountered that issue with learning high level black mage skills then switch to low level red mage that would only learn up to middle tier white and black magic.

my solution ended up being to completely change the class/learning system into a single "build your own class" with equipping skill and learning from skill trees.
some people just made different skill type for each class and having duplicate of skills (like white magic type: cure, and red magic type: cure), that system just looked weird to me with skill learn plugin (literally had to learn "Cure" twice) but was fine when it was only level X learning.

every thread ive seen of issues involving class change + skill learn i dont think ever got solved because they would all involve changing the .js files in different ways unique to each different class and skill type approach. and there's been at least a dozen different approaches.
these 2 plugins when combined definitely the combo with the most issues.

you wouldnt be the 1st to just opt out of the class change plugin and just use evented class change system. or the vise versa of opting out of the skill learn plugin and use other methods to buy skills.
Fortunately the initial problem you pose is actually something that I intend. The act of levelling weapon skills in one class, then switching to another class to focus on, say, black magic, while still enjoying the benefits of your weapon skills.

UN-fortunately it does seem like I might have to end up opting out of the Class System. Though, if this really has been such an impossible to fix problem, it'd be great for some messiah coder to descend and resolve it for good. Thank you though ^^
 

CarbonatedBlood

Villager
Member
Joined
Sep 15, 2021
Messages
8
Reaction score
1
First Language
English
Primarily Uses
RMVXA
Believe it or not it seems like my problem is "resolved". I gave equip weapon types to classes, then equip skill types to the weapons themselves. It seems to have solved my problem for now funny enough.
 

Roninator2

Gamer
Veteran
Joined
May 22, 2016
Messages
3,353
Reaction score
791
First Language
English
Primarily Uses
RMVXA
@CarbonatedBlood you shouldn't need to do that. Gets more complicated.

So what do you want to happen?
I can make it show all skill types but only show the ones you can learn or I can only show the skill types for the classes that are active.

for #2 just comment out one line in the class script. or put this below it.
Ruby:
class Window_LearnSkillCommand < Window_Command
  def include?(stype_id)
    return true if @actor.added_skill_types.include?(stype_id)
    return false
  end
end
 

CarbonatedBlood

Villager
Member
Joined
Sep 15, 2021
Messages
8
Reaction score
1
First Language
English
Primarily Uses
RMVXA
@CarbonatedBlood you shouldn't need to do that. Gets more complicated.

So what do you want to happen?
I can make it show all skill types but only show the ones you can learn or I can only show the skill types for the classes that are active.

for #2 just comment out one line in the class script. or put this below it.
Ruby:
class Window_LearnSkillCommand < Window_Command
  def include?(stype_id)
    return true if @actor.added_skill_types.include?(stype_id)
    return false
  end
end
I would like for the learn skill menu to display only the skill types that the current player class can make use of.
 

Roninator2

Gamer
Veteran
Joined
May 22, 2016
Messages
3,353
Reaction score
791
First Language
English
Primarily Uses
RMVXA
Are you going to use subclasses?
I would recommend Estriole subclass addon.
and the patch I wrote above

You can also possible use these.

There are a few patches and scripts I made for these yanfly scripts. Do a search for them
search for 'estriole' posted by roninator2
 
Last edited:

Latest Threads

Latest Posts

Latest Profile Posts

Cosmetix.gif

Hey man, why don't you do some progress on your game? Oh, because you'd rather wake up at 5am and spend the night making a cosmetics system for your side view battlers? Ok.
spillycup wrote on Finnuval's profile.
i love u so much! i’m so happy you’re in my life right now :kaocry:
To my horror, I found out I got zero Jack Vance books in my bookshelf! :kaoback: Where do y'all go in the internet to buy used books? Like, not Amazon?
Marquise* wrote on Mrs_Allykat's profile.
Your new logo is sooooo attractive! Feels like those sour liquid candy mixed with the wrapping of the popping candy rocks ones. ^^ It gives flavor and taste to our eyes. ^^
Sorry I couldn't comment before, I relogged here for someone's B-Day yesterday. ((Yeah yeah... been scared got on the throne and all as usual. Being social seems harder than walking now. So sorry to everyone and especially you.))
How goes the game make?

Forum statistics

Threads
116,991
Messages
1,103,613
Members
152,874
Latest member
geoffreighbigginshire
Top