kirbwarrior

Veteran
Veteran
Joined
Nov 13, 2014
Messages
1,164
Reaction score
1,024
First Language
English
Primarily Uses
N/A

I was trying to add multiple skill types to my skills so that (for instance) I could seal all "Core" skills regardless of if they are "Magic" or "Special". I was able to get the plugin working in the menu easily enough, but sealing a skill type doesn't seem to work right. In a new project I did the following;

Heal is made a Special skill and the notetag <Skill Type: 1>
Spark has the notetag <Skill Type: 2>
Harold adds the skill type Special and seals Magic in Traits

Only Spark is sealed in both a Battle Test and a Play Test with an event that calls the same battle even though both should be. No other plugins used (or required) and adding Yanfly's Core Engine, Battle Engine Core, and Skill Core had no effect or change. Anyone know what I could be doing wrong?
 

Sword_of_Dusk

Ace Attorney
Veteran
Joined
Sep 13, 2015
Messages
1,019
Reaction score
1,035
First Language
English
Primarily Uses
RMMV
@kirbwarrior If you give Spark the same parameters as Heal, does it still remain sealed during Battle Test and Play Test?
 

kirbwarrior

Veteran
Veteran
Joined
Nov 13, 2014
Messages
1,164
Reaction score
1,024
First Language
English
Primarily Uses
N/A
Tested it out; When I switch Spark over to be the same as Heal, neither is blocked. When I then switch Heal (so they are reversed from my initial post), Heal is blocked. And when they are both Magic with <Skill Type: 2>, they are sealed. Basically, "Seal" isn't seeing the added skill types.
 

Anastasius

Veteran
Veteran
Joined
Feb 7, 2022
Messages
56
Reaction score
40
First Language
English
Primarily Uses
RMMV
Tested it out; When I switch Spark over to be the same as Heal, neither is blocked. When I then switch Heal (so they are reversed from my initial post), Heal is blocked. And when they are both Magic with <Skill Type: 2>, they are sealed. Basically, "Seal" isn't seeing the added skill types.
Hello. Look for line #112:
JavaScript:
var length = skill.skillTypes;
Replace that with:
JavaScript:
var length = skill.skillTypes.length;
 

JohnDoeNews

Mod on Steam (MV/MZ)
Veteran
Joined
Apr 25, 2017
Messages
1,539
Reaction score
1,138
First Language
Dutch
Primarily Uses
RMMV
If magic is never learned, there is nu reason to seal it. Sealing it might be the reason why skills that have both types are sealed too.
 

ATT_Turan

Forewarner of the Black Wind
Veteran
Joined
Jul 2, 2014
Messages
6,947
Reaction score
4,789
First Language
English
Primarily Uses
RMMV
If magic is never learned, there is nu reason to seal it. Sealing it might be the reason why skills that have both types are sealed too.
I think you might have read it backwards - the OP wanted both of the skills to be sealed, but they weren't. :wink:

As far as the first part, you don't always know who is going to get a state/equipment/whatever that's sealing skills. In fact, I'd suggest you usually don't.
 

JohnDoeNews

Mod on Steam (MV/MZ)
Veteran
Joined
Apr 25, 2017
Messages
1,539
Reaction score
1,138
First Language
Dutch
Primarily Uses
RMMV
Oh, oops. :p I thought the character uses special, but not magic so magic was sealed. My mistake.
 

kirbwarrior

Veteran
Veteran
Joined
Nov 13, 2014
Messages
1,164
Reaction score
1,024
First Language
English
Primarily Uses
N/A
Replace that with:
That fixed it perfectly, thanks a lot! Also, looking at that code, it seems like that is just coded wrong in the first place. Does anyone know what I should do to submit this as a bug?

If magic is never learned, there is nu reason to seal it. Sealing it might be the reason why skills that have both types are sealed too.
Actually, I was doing this to solve a different issue. I have multiple state ideas that slightly restrict what the user can do. For instance, "Berserk" disallows skills that don't do damage, "Confusion" disallows skills that target, etc. Some of them I think I could find a way to solve, but being able to 'tag' a skill seemed like a useful idea anyway so I was testing sealing types the player never gains and thus the issue. To really test it, I made a third skill type and sealed it without giving it to Harold and it did exactly what I expected when that was added to Spark and not Heal.
 

Latest Threads

Latest Profile Posts

Now that I have linklists on large trees and cars, is there any theme that would interest you?
Debugging multiplayer issues... I'm having fun, right?
yay_streaming.jpg

For just starting streaming on the 10th... Definitely not the worst. :LZScheeze:

Granted I need 333.34 hours a month on average to achieve money. So I don't really expect that, but it sure has helped my game dev go much faster.
Proud on how this map turned out.

FnmhDLIXgAAOvIC
I just finally fixed a huge problem that wouldn’t let my game load and would crash it.. I thought that I was gonna have to trash the project and start over lol

Forum statistics

Threads
128,327
Messages
1,193,634
Members
168,809
Latest member
AngelChan
Top