RMMV YEP Multi-Type Skills not fully giving multiple types

[kirbwarrior]

Multi-Type Skills (YEP) - Yanfly.moe Wiki

www.yanfly.moe

I was trying to add multiple skill types to my skills so that (for instance) I could seal all "Core" skills regardless of if they are "Magic" or "Special". I was able to get the plugin working in the menu easily enough, but sealing a skill type doesn't seem to work right. In a new project I did the following;

Heal is made a Special skill and the notetag <Skill Type: 1>
Spark has the notetag <Skill Type: 2>
Harold adds the skill type Special and seals Magic in Traits

Only Spark is sealed in both a Battle Test and a Play Test with an event that calls the same battle even though both should be. No other plugins used (or required) and adding Yanfly's Core Engine, Battle Engine Core, and Skill Core had no effect or change. Anyone know what I could be doing wrong?

 

[Sword_of_Dusk]

@kirbwarrior If you give Spark the same parameters as Heal, does it still remain sealed during Battle Test and Play Test?

 

[kirbwarrior]

Tested it out; When I switch Spark over to be the same as Heal, neither is blocked. When I then switch Heal (so they are reversed from my initial post), Heal is blocked. And when they are both Magic with <Skill Type: 2>, they are sealed. Basically, "Seal" isn't seeing the added skill types.

 

[Anastasius]

Tested it out; When I switch Spark over to be the same as Heal, neither is blocked. When I then switch Heal (so they are reversed from my initial post), Heal is blocked. And when they are both Magic with <Skill Type: 2>, they are sealed. Basically, "Seal" isn't seeing the added skill types.

Hello. Look for line #112:

var length = skill.skillTypes;

Replace that with:

var length = skill.skillTypes.length;

 

[JohnDoeNews]

If magic is never learned, there is nu reason to seal it. Sealing it might be the reason why skills that have both types are sealed too.

 

[ATT_Turan]

If magic is never learned, there is nu reason to seal it. Sealing it might be the reason why skills that have both types are sealed too.

I think you might have read it backwards - the OP wanted both of the skills to be sealed, but they weren't.

As far as the first part, you don't always know who is going to get a state/equipment/whatever that's sealing skills. In fact, I'd suggest you usually don't.

 

[JohnDoeNews]

Oh, oops. I thought the character uses special, but not magic so magic was sealed. My mistake.

 

[kirbwarrior]

Replace that with:

That fixed it perfectly, thanks a lot! Also, looking at that code, it seems like that is just coded wrong in the first place. Does anyone know what I should do to submit this as a bug?

If magic is never learned, there is nu reason to seal it. Sealing it might be the reason why skills that have both types are sealed too.

Actually, I was doing this to solve a different issue. I have multiple state ideas that slightly restrict what the user can do. For instance, "Berserk" disallows skills that don't do damage, "Confusion" disallows skills that target, etc. Some of them I think I could find a way to solve, but being able to 'tag' a skill seemed like a useful idea anyway so I was testing sealing types the player never gains and thus the issue. To really test it, I made a third skill type and sealed it without giving it to Harold and it did exactly what I expected when that was added to Spark and not Heal.