YR Plugins

Discussion in 'JS Plugin Releases (RMMV)' started by Waterguy, Oct 2, 2016.

  1. fallenlorelei

    fallenlorelei Veteran Veteran

    Messages:
    295
    Likes Received:
    333
    First Language:
    English
    Wow, thank you for the quick response! Wasn't expecting that :)

    Unfortunately, same error. This time on .js:3137:84.

    That being said, could you explain the difference between "CRAFT LEARN ITEM itemId" and "CRAFT LEARN ITEM itemId recipe" - I tried both with neither working. You mentioned the command I used was to "learn all recipes for one item", which I don't quite understand.
     
    #81
  2. Waterguy

    Waterguy Veteran Veteran

    Messages:
    1,164
    Likes Received:
    250
    Location:
    Brazil
    First Language:
    Portuguese
    Primarily Uses:
    RMMV
    @fallenlorelei oh, I think it really was your error...
    Reading again your explanation, the recipe notetags are in the item 39? Then you won't need the line "Result Item 39" (unless you want to create two pies). And you'll call the "CRAFT LEARN ITEM 39", not 57.
    If I am right, the problem here is that item 57 has no recipe, thus you are learning nothing from it. I'll add an error check for this. Sorry.

    The difference is... an item in this plugin can have more than one recipe for it. "CRAFT LEARN ITEM itemId" learns all of them, while "CRAFT LEARN ITEM itemId recipeId" only learns one of them at a time.
    Like, you can have a pie recipe with all ingredients, or you can have one with Pie Mix.
     
    #82
  3. fallenlorelei

    fallenlorelei Veteran Veteran

    Messages:
    295
    Likes Received:
    333
    First Language:
    English
    @Waterguy Okay, I see! So I think I'm confused about what item needs the <Recipe> notetag. I had the notetag in Item 57, which is just an otherwise empty item called Recipe: Pie. The Pie itself is Item 39. That's why I had "Result Item 39."

    But I moved the <Recipe> notetag to Item 39 and still get the error when I try opening up the screen. I tried changing the plugin command to CRAFT LEARN ITEM 57, CRAFT LEARN ITEM 39, CRAFT LEARN ITEM 39 57...

    At this point I have the <Recipe> notetag in both items just to see what works, lol.
     
    #83
  4. Waterguy

    Waterguy Veteran Veteran

    Messages:
    1,164
    Likes Received:
    250
    Location:
    Brazil
    First Language:
    Portuguese
    Primarily Uses:
    RMMV
    Give me some more time then, I'll need to make a new project to see if I can find the problem...
     
    #84
  5. fallenlorelei

    fallenlorelei Veteran Veteran

    Messages:
    295
    Likes Received:
    333
    First Language:
    English
    Thanks so much for your help. If it helps, I set the "CRAFT LEARN ITEM id" to an autorun plugin command, and get the error upon opening a new game, so it looks like it has to do with how I set up the notetag or how I'm trying to learn the recipe - and not how I'm opening up the crafting window.
     
    #85
  6. Waterguy

    Waterguy Veteran Veteran

    Messages:
    1,164
    Likes Received:
    250
    Location:
    Brazil
    First Language:
    Portuguese
    Primarily Uses:
    RMMV
    @fallenlorelei the error was mine, in the end.
    I think I fixed your error, and even found and fixed another one that happens when you don't have YEP_ItemCore.

    Here you go, if it doesn't work don't forget to warn me!
     
    #86
  7. fallenlorelei

    fallenlorelei Veteran Veteran

    Messages:
    295
    Likes Received:
    333
    First Language:
    English
    @Waterguy I really do immensely thank you for helping me out, I've never gotten assistance from a plugin dev like this before! I feel bad I'm taking up a full page of errors here!

    So the good news is, I have
    CRAFT LEARN ITEM 39
    set up as an autorun, and my game doesn't crash!

    Bad news is when I try to open up the crafting window with
    CRAFT START 2
    I get this error...

    YRCraftingHelp4.JPG

    I think that happens when I don't have any recipes learned (I've seen it come up during my testing when I forget to 'learn' anything). Maybe it's my syntax?

    Item 39 is "Pie"
    Notetag is
    <Recipe>
    Discipline: 2
    Category: Food
    Ingredient Item 22
    </Recipe>

    (simplified the ingredient list just for testing purposes)

    Discipline 2 is "Fireplace" in the plugin settings. "Food" is a category within Fireplace, and the only "Food" category of the bunch. Not sure if relevant, just trying to make sure I cover my bases.

    YRCraftingHelp5.JPG

    The guy who was posting before me got far enough to open up the crafting window. The plugin worked for him, and works for you! I'm probably just making a really dumb mistake.

    Edit: Okay @Waterguy , I put your new plugin in a new game without any other plugins, and it works! So all along it's been something else on my end. Oof. Time to figure out what's causing the incompatibility...

    @Waterguy maybe not the plugin we'd expect, but it is YEP_ItemCore causing the error! Once I've turned that off, I was able to successfully learn a recipe, and open up the crafting window!
     
    Last edited: Feb 2, 2019
    #87
  8. Waterguy

    Waterguy Veteran Veteran

    Messages:
    1,164
    Likes Received:
    250
    Location:
    Brazil
    First Language:
    Portuguese
    Primarily Uses:
    RMMV
    Really? Weird, I made this plugin to work with YEP_ItemCore... I'll have to fix this.
    Thank you, @fallenlorelei , I'll work on a fix right now!

    EDIT: @fallenlorelei I can't reproduce the error... my project I made to test only got the two plugins, and no error is showing up...
     
    Last edited: Feb 2, 2019
    #88
  9. fallenlorelei

    fallenlorelei Veteran Veteran

    Messages:
    295
    Likes Received:
    333
    First Language:
    English
    @Waterguy I also got no error in my test project with only those 2 items.
    But then I switched "Updated Scene Item" in ItemCore to "False" (as it is in my original game), and BAM - error. Doesn't it feel good when you figure things out??

    Went to my original game, turned Updated Scene Item to Updated, and everything works.

    So, I'm not a huge fan of the updated item scene because it provides extra information unnecessary to my players (stats I don't use, a big window on the right side that's empty most of the time, etc. etc.) I would like to keep using the default scene. Would you have an idea of how to patch this up? :)

    Thanks for your patience, 'guy!

    In the meantime as I dev this, I'll just use the updated scene.

    Edit: New question, @Waterguy. Have you considered adding support for Max Items? In Yanfly's original Item Synthesis, it wouldn't let you craft more than the max item listed, and it would gray out in the crafting scene if you already had the max.

    I switched from MrT's since I assumed this one would support that but I was wrong :LZSblush: oof. I might go back to Yanfly's if this is too difficult to implement, although dealing with the lack of disciplines might be a headache.
     
    Last edited: Feb 3, 2019
    #89
  10. Waterguy

    Waterguy Veteran Veteran

    Messages:
    1,164
    Likes Received:
    250
    Location:
    Brazil
    First Language:
    Portuguese
    Primarily Uses:
    RMMV
    @fallenlorelei
    Sorry for taking so long to answer, yesterday was the last day of a friend living in town.

    I didn't even think this was a possibility of a problem... I used the Window_ItemInfo from Yanfly's Item Core, since Independent Items come from them... it seems like it isn't declared outside the check if the new menu is used, so I'll have to write my own window there...

    I also completely forgot about max items. My plugin allows you to use evals as requirements, meaning you could jury-rig it yourself, but you are right, it should be a default feature.
    So I added this.

    By the way, did you ever notice that, for items set as non-independent with a dependent kind, like a potion set as non-independent when you have independent items, their max number is set through YEP_CoreEngine? You can only have that many kinds of items though.

    Anyway, I updated it, hopefully everything is working fine now.
    Even fixed the bug of always making the confirmation sound.
    (Hope I didn't end up creating new ones...)

    Here you go.
     
    #90
    SwiftIllusion likes this.
  11. fallenlorelei

    fallenlorelei Veteran Veteran

    Messages:
    295
    Likes Received:
    333
    First Language:
    English
    @Waterguy No worries, I was out yesterday too!

    But I love it! It works! No crashing, it gives me the appropriate error sound when I'm already at max items. It's great!

    I guess if I could be so terrible and provide a wishlist of adjustments, LOL, for whenever you are bored and free and want to spruce it up:
    • Visual cue if at max item. Right now it just plays a sound, which works, but it'd be nice if we could gray out the selection in the window or something like that.
    • As I was playing with this, I found myself missing the item description window. Mostly because in my game, it has an explanation for how many items I can currently hold. (For example, the actor's Quiver equipment determines how many Arrows they can hold; likewise for a Belt and Tools, etc.)
    • When you can select the Quantity, can you stop the #s from going up when they reach max?
    • If we have a title for "Results," can we have a title for "Ingredients"?
    I made an ugly mockup of what I mean.
    YRCraftingMockup.jpg

    I'm just being spoiled and selfish at this point. I do want to thank you for getting this to work!! I'm definitely going to use it in my game now. You are amazing.
     
    #91
  12. Waterguy

    Waterguy Veteran Veteran

    Messages:
    1,164
    Likes Received:
    250
    Location:
    Brazil
    First Language:
    Portuguese
    Primarily Uses:
    RMMV
    Ok, I did an update for Item Crafting, now you can show the description of the item and the quantity window won't let you choose more items than you can craft, instead of just denying you creating it.

    Also added:
    A stretch fix for SRD's Character Creator Ex (usually, when you make the faces appear in a box not perfectly square, the top and bottom are cut a bit. SRD's was stretching them to fit instead. This makes the face be cut like usual).
    An enemy weakness display plugin (based on Persona). It also has some free icons made by a friend under the condition I released the plugin and them to public instead of keeping to myself. It is based on Olivia's plugin of the same effect, just my personal take on it... so it is in Personal Edits.
    A battle formation plugin. Based in the Breath of Fire series. It is technically also a take on someone else's plugin, this time one by Ninaroku. So, also in Personal Edits. This one allows more than 3 party members and is supposedly compatible with Yanfly's Party System though.
     
    #92
  13. Summer夏

    Summer夏 Villager Member

    Messages:
    23
    Likes Received:
    6
    First Language:
    中文
    Primarily Uses:
    RMMV
    Hello, YR_X_ElementalRateCode doesn't seem to work. If you have time, can you fix it?
     
    #93
  14. Waterguy

    Waterguy Veteran Veteran

    Messages:
    1,164
    Likes Received:
    250
    Location:
    Brazil
    First Language:
    Portuguese
    Primarily Uses:
    RMMV
    @Summer夏 by "doesn't seem to work" what exactly did you try? How is your code? Is the plugin under Yanfly's Elemental Core?
     
    #94
  15. Summer夏

    Summer夏 Villager Member

    Messages:
    23
    Likes Received:
    6
    First Language:
    中文
    Primarily Uses:
    RMMV
    Thank you for your timely reply. I think I made a mistake. I think this plug-in set element damage.I am looking for a similar plugin.
     
    #95
  16. GammaVD

    GammaVD Veteran Veteran

    Messages:
    70
    Likes Received:
    3
    First Language:
    English
    Ok so I seem to be getting an conflict error from Yanflys Equip Core when using <Custom Parameters> and YR_NewParameters (I don't think it likes me using the new parameters, but it even flags ones that don't use them in the error log)

    It still runs but because I have so many weapons and armour using <Custom Parameters> the 334 errors makes the game lag like hell (thats on load and any time it looks at equipment)
     
    #96
  17. Waterguy

    Waterguy Veteran Veteran

    Messages:
    1,164
    Likes Received:
    250
    Location:
    Brazil
    First Language:
    Portuguese
    Primarily Uses:
    RMMV
    @GammaVD could you show an example of such an error? And of your custom parameter code?
    It was kinda made to be used with Equip Core, so...
     
    #97
  18. GammaVD

    GammaVD Veteran Veteran

    Messages:
    70
    Likes Received:
    3
    First Language:
    English
    upload_2019-3-27_10-14-42.png
    In amongst them I saw at least 1 that was just [mat = 2] so don't really know whats going on
     
    #98
  19. Waterguy

    Waterguy Veteran Veteran

    Messages:
    1,164
    Likes Received:
    250
    Location:
    Brazil
    First Language:
    Portuguese
    Primarily Uses:
    RMMV
    @GammaVD
    those seem to be enemy level errors, not equip core... but it is weird because I use all three together...
    there seems to be something wrong with your formula, "custom parameter formula error"... also "maximum call stack size exceeded", something is causing it to enter a deadlock - it is in a loop that doesn't end.
    What exactly is your dext base formula?
     
    #99
  20. GammaVD

    GammaVD Veteran Veteran

    Messages:
    70
    Likes Received:
    3
    First Language:
    English
    The Enemy Level is just the last Yanfly plugin in the list, if I turn it of the next one throws the error, I think its just handling the error messaging.
    If I turn either Equip Core or New Parameters off the errors don't occur, so its something to do with <Custom Parameters>

    (base + plus) * paramRate * buffRate + flat

    its just a single value, no formulas, nothing else is changing the value, but as I said, the game does still run, I can get in and move around, its just very laggy loading up and opening equipment
     

Share This Page